Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DDP_SPAWN compatibility with bug_report_model.py #6892

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

ethanwharris
Copy link
Member

@ethanwharris ethanwharris commented Apr 8, 2021

What does this PR do?

Fixes a small issue in bug_report_model.py where accelerator='ddp_spawn' gives the following error:
AttributeError: Can't pickle local object 'test_run.<locals>.TestModel'

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@carmocca carmocca added this to the 1.3 milestone Apr 8, 2021
@carmocca carmocca enabled auto-merge (squash) April 8, 2021 13:44
@carmocca carmocca added the ready PRs ready to be merged label Apr 8, 2021
@carmocca carmocca merged commit 87f0aea into master Apr 8, 2021
@carmocca carmocca deleted the bugfix/bug_report_model branch April 8, 2021 14:27
@SeanNaren SeanNaren mentioned this pull request Apr 12, 2021
SeanNaren pushed a commit that referenced this pull request Apr 13, 2021
lexierule pushed a commit that referenced this pull request Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working example ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants