Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Drop brew update #6985

Merged
merged 1 commit into from
Apr 13, 2021
Merged

[CI] Drop brew update #6985

merged 1 commit into from
Apr 13, 2021

Conversation

SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented Apr 13, 2021

What does this PR do?

Voodoo I think has fixed the issue...

Fixes #<issue_number>

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@SeanNaren SeanNaren added the ci Continuous Integration label Apr 13, 2021
@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #6985 (c0d9bad) into master (644e7aa) will decrease coverage by 5%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #6985    +/-   ##
=======================================
- Coverage      92%     87%    -5%     
=======================================
  Files         194     194            
  Lines       12368   12368            
=======================================
- Hits        11349   10699   -650     
- Misses       1019    1669   +650     

@SeanNaren SeanNaren marked this pull request as ready for review April 13, 2021 10:47
@SeanNaren SeanNaren requested a review from a team April 13, 2021 10:47
@kaushikb11 kaushikb11 enabled auto-merge (squash) April 13, 2021 11:01
@kaushikb11 kaushikb11 merged commit 23e8dff into master Apr 13, 2021
@kaushikb11 kaushikb11 deleted the ci/drop_update branch April 13, 2021 11:06
SeanNaren pushed a commit that referenced this pull request Apr 13, 2021
(cherry picked from commit 23e8dff)
@SeanNaren SeanNaren mentioned this pull request Apr 13, 2021
awaelchli pushed a commit that referenced this pull request Apr 13, 2021
(cherry picked from commit 23e8dff)
lexierule pushed a commit that referenced this pull request Apr 14, 2021
(cherry picked from commit 23e8dff)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants