Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Add split support in from folders #152

Closed
aribornstein opened this issue Feb 28, 2021 · 1 comment
Closed

Add split support in from folders #152

aribornstein opened this issue Feb 28, 2021 · 1 comment
Assignees
@edgarriba
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone
v0.3

Comments

@aribornstein
Copy link
Contributor

🚀 Feature

From ImageClassificationData.from_filepaths allows me to define splits for validation but from ImageClassificationData.from_folders does not this is inconsistent and should be a standard feature.
@aribornstein aribornstein added enhancement New feature or request help wanted Extra attention is needed labels Feb 28, 2021
@edenlightning edenlightning added this to the 0.2 milestone Mar 22, 2021
@edenlightning edenlightning modified the milestones: 0.2, 0.3 Apr 19, 2021
@edgarriba
Copy link
Contributor

@aribornstein this come after #141 . See: https://github.com/PyTorchLightning/lightning-flash/blob/44d70e16ae74f890376a2a52175ef9c43e2b0291/flash/data/data_module.py#L379

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@edgarriba edgarriba

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
v0.3
Development

No branches or pull requests
4 participants
@aribornstein @edgarriba @ethanwharris @edenlightning