Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Add face detection CLI #1170

Merged
merged 2 commits into from
Feb 14, 2022
Merged

Add face detection CLI #1170

merged 2 commits into from
Feb 14, 2022

Conversation

ethanwharris
Copy link
Collaborator

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@ethanwharris ethanwharris added the enhancement New feature or request label Feb 14, 2022
@ethanwharris ethanwharris added this to the v0.7 milestone Feb 14, 2022
@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #1170 (cd3a563) into master (3c84e94) will increase coverage by 0.67%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1170      +/-   ##
==========================================
+ Coverage   90.20%   90.88%   +0.67%     
==========================================
  Files         285      286       +1     
  Lines       12745    12758      +13     
==========================================
+ Hits        11497    11595      +98     
+ Misses       1248     1163      -85     
Flag Coverage Δ
unittests 90.88% <100.00%> (+0.67%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/__main__.py 95.23% <ø> (ø)
...ash/image/classification/integrations/baal/loop.py 94.77% <ø> (ø)
flash/image/face_detection/model.py 91.89% <ø> (+56.75%) ⬆️
...ash/image/classification/integrations/baal/data.py 93.93% <100.00%> (+0.12%) ⬆️
flash/image/face_detection/cli.py 100.00% <100.00%> (ø)
flash/image/face_detection/output_transform.py 100.00% <100.00%> (+55.55%) ⬆️
flash/text/question_answering/model.py 92.71% <0.00%> (+0.66%) ⬆️
flash/image/face_detection/data.py 82.60% <0.00%> (+8.69%) ⬆️
flash/image/face_detection/input.py 100.00% <0.00%> (+14.28%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c84e94...cd3a563. Read the comment docs.

@ethanwharris ethanwharris added the tests / CI Tests and continuous integration label Feb 14, 2022
@ethanwharris ethanwharris merged commit 4c62482 into master Feb 14, 2022
@ethanwharris ethanwharris deleted the feature/face_cli branch February 14, 2022 21:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request tests / CI Tests and continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant