Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Fix icevision task metric names #1252

Merged
merged 3 commits into from
Mar 28, 2022
Merged

Conversation

ethanwharris
Copy link
Collaborator

What does this PR do?

Part of #1244

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@ethanwharris ethanwharris added the bug / fix Something isn't working label Mar 25, 2022
@ethanwharris ethanwharris added this to the 0.7.x milestone Mar 25, 2022
@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #1252 (e7786c7) into master (536dbfc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1252   +/-   ##
=======================================
  Coverage   91.18%   91.19%           
=======================================
  Files         286      286           
  Lines       12790    12793    +3     
=======================================
+ Hits        11662    11666    +4     
+ Misses       1128     1127    -1     
Flag Coverage Δ
unittests 91.19% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/data/utils.py 90.41% <ø> (ø)
flash/core/integrations/icevision/adapter.py 87.91% <ø> (ø)
flash/core/integrations/icevision/wrappers.py 78.26% <100.00%> (+3.26%) ⬆️
flash/text/question_answering/model.py 92.56% <0.00%> (+0.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 536dbfc...e7786c7. Read the comment docs.

Copy link
Contributor

@krshrimali krshrimali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment to pass the stage directly instead of the whole adapter. :) Otherwise, LGTM. thank you so much!

@ethanwharris ethanwharris merged commit 64e7589 into master Mar 28, 2022
@ethanwharris ethanwharris deleted the bugfix/icevision_metrics branch March 28, 2022 16:06
ethanwharris added a commit that referenced this pull request Mar 30, 2022
Co-authored-by: Kushashwa Ravi Shrimali <kushashwaravishrimali@gmail.com>
ethanwharris added a commit that referenced this pull request Mar 30, 2022
Co-authored-by: Kushashwa Ravi Shrimali <kushashwaravishrimali@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug / fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants