This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
[feat] Add support for schedulers #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaton
requested review from
Borda,
carmocca,
justusschock and
kaushikb11
as code owners
Codecov Report
@@ Coverage Diff @@
## master #232 +/- ##
=======================================
Coverage 86.56% 86.56%
=======================================
Files 57 58 +1
Lines 2843 2910 +67
=======================================
+ Hits 2461 2519 +58
- Misses 382 391 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
SeanNaren
reviewed
Apr 21, 2021
| else: | ||
| dataset_size = len(self.train_dataloader()) | ||
|
|
||
| num_devices = max(1, self.trainer.num_gpus, self.trainer.num_processes) |
There was a problem hiding this comment.
Maybe someone else can confirm, but I think num_gpus is automatically set to num_processes now, so this isn't needed, we should be able to do just num_devices = num_processes
SeanNaren
approved these changes
Apr 21, 2021
edgarriba
reviewed
Apr 21, 2021
flash/core/schedulers.py
Outdated
|
|
||
| if _TRANSFORMERS_AVAILABLE: | ||
| from transformers import optimization | ||
| functions = [getattr(optimization, n) for n in dir(optimization) if ("get_" in n and n != 'get_scheduler')] |
There was a problem hiding this comment.
Suggested change
| functions = [getattr(optimization, n) for n in dir(optimization) if ("get_" in n and n != 'get_scheduler')] | |
| functions: List[Callable] = [getattr(optimization, n) for n in dir(optimization) if ("get_" in n and n != 'get_scheduler')] |
ethanwharris
approved these changes
Apr 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR add a better support for optimizer and schedulers.
Fixes # (issue)
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃