This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Add text embedder #996
Merged
Add text embedder #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhijithneilabraham
requested review from
ananyahjha93,
Borda,
carmocca,
ethanwharris,
justusschock,
kaushikb11 and
tchaton
as code owners
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #996 +/- ##
==========================================
+ Coverage 86.71% 86.74% +0.02%
==========================================
Files 266 269 +3
Lines 13809 13870 +61
==========================================
+ Hits 11974 12031 +57
- Misses 1835 1839 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
tchaton
reviewed
Dec 8, 2021
flash_examples/text_embedder.py
Outdated
| ) | ||
|
|
||
| # 2. Load a previously trained SentenceEmbedder | ||
| model = SentenceEmbedder(backbone="sentence-transformers/paraphrase-multilingual-MiniLM-L12-v2") |
There was a problem hiding this comment.
Would you mind adding some tests to increase the coverage ?
There was a problem hiding this comment.
Yes. On it now.
There was a problem hiding this comment.
@tchaton I just commited a test but I am not sure if it is the right way you want it to be. Please do a review and let me know how I can improve.
for more information, see https://pre-commit.ci
ethanwharris
reviewed
Dec 9, 2021
for more information, see https://pre-commit.ci
ethanwharris
reviewed
Dec 9, 2021
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #760