Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Google Analytics 연동 리팩토링 #46

Merged
merged 1 commit into from
Sep 10, 2024
Merged

refactor: Google Analytics 연동 리팩토링 #46

merged 1 commit into from
Sep 10, 2024

Conversation

ArpaAP
Copy link
Member

@ArpaAP ArpaAP commented Sep 10, 2024 •
edited
Loading

구현한 기능

  • index.html에 script 삽입 대신 vite-plugin-radar 플러그인 적용하여 GA 적용
  • 개발 시 dev 환경도 GA tracking 되는 문제가 있어 production 환경에서만 GA 활성화 되도록 수정

논의하고 싶은 내용

기타

toothlessdev
toothlessdev approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@toothlessdev toothlessdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@WithJo WithJo merged commit d0b99b7 into develop Sep 10, 2024
2 checks passed
@ArpaAP ArpaAP deleted the refactor/ga branch September 10, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toothlessdev toothlessdev toothlessdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArpaAP @toothlessdev @WithJo