Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dice role improvement #16

Open
VelkanGk opened this issue Sep 6, 2020 · 3 comments
Open

Dice role improvement #16

VelkanGk opened this issue Sep 6, 2020 · 3 comments

Comments

@VelkanGk
Copy link

VelkanGk commented Sep 6, 2020

Hi @LilithTheSuccubus !
I have merged and improved the dice rolling command so you can have any dice allocation and modifiers in the same cmd and also without having to specify a command first
imagen

How can I send you my code for you to review it?

@LilithTheDeveloper
Copy link
Owner

Hello Velkan,

This looks like an amazing improvement! You should be able to create a request, where I can then merge it with the main project.

Thanks for your efforts!

@LilithTheDeveloper
Copy link
Owner

I have now reviewed the code, I would merge most of it, with the exception of one thing. The D20 command is not just a simple D20 role, it is handled different than the other kinds of roll. In a different version of the bot I use, it is implemented with various neat to have things.

@VelkanGk
Copy link
Author

VelkanGk commented Sep 7, 2020

Oh! yeah, sure! My bad, sorry, I misread the command d20. In that case it could be set to start with numbers or a new command
!1d100+10 or !r 1d100+10 in order to d20 to keep executing as normal. Would you like me to apply those changes? =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants