Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultivarDecomp.modeplot() arguments - new default + fix when archiveType is not provided #514

Closed
khider opened this issue Feb 8, 2024 · 2 comments
Assignees

Comments

@khider
Copy link
Member

khider commented Feb 8, 2024

When the archiveType is not provided in the GeoSeries, the map doesn't make much sense using the defaults:

Problem 1:

image

The work around is to set marker='o' but I would expect that by default, I get something better than question marks when archiveType (default for marker setting) is None. I would write a condition that if archiveType is None for all GeoSeries in the MultipleGeoSeries object, then set marker to 'o'.

Problem 2:

The legend on the right doesn't make sense when there are no archiveType provided. But when using the command: scatter_kwargs={'legend':False}, the colorbar disappears.

image

@CommonClimate
Copy link
Collaborator

CommonClimate commented Feb 9, 2024

Solution agreed upon by the High Council on 02/09/2024:

  • make marker=None the default for MultivarDecomp.modeplot()
  • update docstring to mention the possibility of archiveType
  • update the docstring example of MultipleGeoSeries.pca() to specify marker = 'archiveType'

@khider
Copy link
Member Author

khider commented May 3, 2024

Fixed with #525

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants