Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine two MultiSeries objects #19

Closed
kcpevey opened this issue Jan 20, 2023 · 5 comments
Closed

Combine two MultiSeries objects #19

kcpevey opened this issue Jan 20, 2023 · 5 comments
Labels
priority_medium medium priority issue

Comments

@kcpevey
Copy link
Collaborator

kcpevey commented Jan 20, 2023

We need a way to combine two MultiSeries objects. I'm opening this as a separate action item, but I actually think it can be handled in the same way as #18 - via a MultiSeries.add method.

MultiSeries.add(MultiSeries) could detect accept different types (Series, MultiSeries, list of Series) and handle them appropriately.

@CommonClimate
Copy link
Contributor

yes, and same as #18: overloaded + or & method would be most valuable as a shorthand.

@CommonClimate
Copy link
Contributor

CommonClimate commented Jan 21, 2023

the new Series.equals() method should help flag duplicates, and remove them if necessary

@CommonClimate CommonClimate added the priority_medium medium priority issue label Jan 21, 2023
@MarcoGorelli
Copy link

from our side, is this one covered by #18, or is there anything else which needs doing here?

@CommonClimate
Copy link
Contributor

it is not covered. See the latest version of Paleopandas Playground.ipynb for an illustration. AFAICT, #18 only allows to a a Series to a MultipleSeries object, not to combine two MultipleSeries objects. This still needs to be done by the end of the project, but I'm guessing won't be huge ordeal?

@CommonClimate
Copy link
Contributor

CommonClimate commented Mar 3, 2023

Addressed by #354. Still needs a notebook tutorial, or at least informative docstrings on and and add to highlight usage differences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority_medium medium priority issue
Projects
Development

No branches or pull requests

3 participants