Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Travis tests by not supporting node 0.10 and node 0.12 #147

Open
6 tasks
jimmyhchan opened this issue Dec 9, 2017 · 0 comments
Open
6 tasks

Fix Travis tests by not supporting node 0.10 and node 0.12 #147

jimmyhchan opened this issue Dec 9, 2017 · 0 comments

Comments

@jimmyhchan
Copy link
Contributor

Hello 2017 from 2015. #146 added a workaround for a bug shown in Node 8. For sake of semVer we should bump major (or if we insist on keeping with the previous borken tradition of breaking changes in a minor) and require Node 4+.

  • Do a semver friendly bump of package.json version
  • Remove failing 0.10 and 0.12 Travis tests
  • update docs
  • mimic changes in dustjs-linkedin
  • update package.json engines, update dustjs peer dep to this new major/minor
  • push both around the same time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant