From 5d19be71eb665e4aaa42c5d7b6f3c9c29ba4f171 Mon Sep 17 00:00:00 2001 From: Benjamin Gruenbaum Date: Wed, 26 Jan 2022 19:56:47 +0200 Subject: [PATCH] test: improve stability of oom test The OOM test uses a value that caused an OOM crash from V8 on certain machines when V8 did not notify the host of OOM soon enough. PR-URL: https://github.com/nodejs/node/pull/41681 Refs: https://github.com/tc39/proposal-iterator-helpers#asindexedpairs Reviewed-By: Robert Nagy Reviewed-By: Matteo Collina --- test/parallel/test-windows-failed-heap-allocation.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/parallel/test-windows-failed-heap-allocation.js b/test/parallel/test-windows-failed-heap-allocation.js index 56a941ce58d072..be901b7dc2242c 100644 --- a/test/parallel/test-windows-failed-heap-allocation.js +++ b/test/parallel/test-windows-failed-heap-allocation.js @@ -19,8 +19,8 @@ const tmpdir = require('../common/tmpdir'); tmpdir.refresh(); // --max-old-space-size=3 is the min 'old space' in V8, explodes fast -const cmd = `"${process.execPath}" --max-old-space-size=3 "${__filename}"`; -exec(`${cmd} heapBomb`, { cwd: tmpdir.path }, common.mustCall((err) => { +const cmd = `"${process.execPath}" --max-old-space-size=30 "${__filename}"`; +exec(`${cmd} heapBomb`, { cwd: tmpdir.path }, common.mustCall((err, stdout, stderr) => { const msg = `Wrong exit code of ${err.code}! Expected 134 for abort`; // Note: common.nodeProcessAborted() is not asserted here because it // returns true on 134 as well as 0x80000003 (V8's base::OS::Abort)