Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New method to get Volume Name #1

Closed
LinusU opened this issue Jan 7, 2014 · 7 comments
Closed

New method to get Volume Name #1

LinusU opened this issue Jan 7, 2014 · 7 comments

Comments

@LinusU
Copy link
Owner

LinusU commented Jan 7, 2014

The Volume Name currently is an empty string for the root path, (should be e.g. Macintosh HD).

Mounted volume that got a number appended to it also gets wrongly detected, (e.g. Test Title 1 when it should be Test Title).

@szwacz
Copy link

szwacz commented Jan 9, 2014

The Volume Name currently is an empty string for the root path, (should be e.g. Macintosh HD).

Sorry for being lame, but could you tell me when it happens (how to reproduce it)?

@LinusU
Copy link
Owner Author

LinusU commented Jan 10, 2014

https://github.com/LinusU/node-alias/blob/master/lib/create.js#L68

a = require('node-alias');
b = a.create('/bin/mkdir');
i = a.decode(b);
console.log(i);

It occurs when trying to create an alias to any file that is on the root volume.

More importantly for node-ds-store, it also occurs when creating an alias to a volume that is mounted to a folder that has not exactly the same name as the volume name.

@LinusU
Copy link
Owner Author

LinusU commented Jan 10, 2014

@szwacz finding anything useful? The only way I have found is to parse the output from diskutil list but that would mean that we would be back to depending on OS X :(

@LinusU
Copy link
Owner Author

LinusU commented Jan 10, 2014

Might be of interest:

http://stackoverflow.com/questions/18600377/detecting-mounted-drives-on-linux-and-mac-os-x

I guess that a module implemented in c++ would be the best but I haven't found any good apis yet.

@LinusU
Copy link
Owner Author

LinusU commented Jan 10, 2014

It would be really great if it would work on both Linux and Mac. (and Windows would be cool as well)

@szwacz
Copy link

szwacz commented Jan 10, 2014

I was trying to wrap my mind around it all and sorry but this is too much. I just wanted DMG image in shortest way possible, not a general, bullet proof alias parsing/creating utility :)

If it was up to me I would prefer to construct dummy aliases from predefined binary templates (just inject needed data there). Actually background image in DMG will be always in the same location and always with the same name, so it should be a lot easier than this.

@LinusU
Copy link
Owner Author

LinusU commented Jan 13, 2014

Closed in 54361b7

@LinusU LinusU closed this as completed Jan 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants