-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: remove zeabur logo due to no more support #423
Conversation
tools/make/helm.mk
Outdated
@@ -5,7 +5,7 @@ | |||
include tools/make/env.mk | |||
|
|||
|
|||
OCI_REGISTRY ?= oci://${REGISTRY} | |||
OCI_REGISTRY ?= oci://${REGISTRY}/linuxsuren |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We missed here @yuluo-yx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, It defined in env.mk . I include env.mk
Line 10 in 9f400bb
REGISTRY ?= docker.io/linuxsuren |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the makefile is not written perfectly, if there are any other problems, please let me know and I'll fix it as fast as I can! 🫡
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I figured out the reason. See
REGISTRY: ghcr.io |
Actually, docker.io/linuxsuren
is not a registry. Normally a registry should be docker.io
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linuxsuren is similar to namespance, docker.io is registry address . maybe this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will fixed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linuxsuren is similar to namespance, docker.io is registry address . maybe this?
Agree.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed, in #424
There are 20 test cases, failed count 0: See all test records
Reported by api-testing. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more |
There are 1 test cases, failed count 1:
See the error message* Case: CreateStore. error: literal not terminated (2:1) | /healthz", 2400) | ^. body:e2e-testing |
Signed-off-by: Rick <1450685+LinuxSuRen@users.noreply.github.com>
Quality Gate passedIssues Measures |
* chore(deps): update moonrailgun/tailchat docker tag to v1.9.0 * Update app version [skip ci] --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: github-action update-app-version <githubaction@githubaction.com>
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #