Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): upgrade cosmiconfig to v8.3.6 #211

Merged
merged 1 commit into from
Aug 18, 2024
Merged

Conversation

okize
Copy link
Contributor

@okize okize commented Aug 16, 2024

There should be no significant breaking changes by upgrading to v8 (https://github.com/cosmiconfig/cosmiconfig/blob/main/CHANGELOG.md#800) it just drops support for older versions of NodeJS.

I'm trying to avoid new CommonJS files in my repo & the benefit to this change will be supporting ESM by default: cosmiconfig/cosmiconfig#224

However, there is a workaround with resolutions in my package.json:

  "resolutions": {
    "cosmiconfig": "^8.3.6"
  },

Note: there is a more recent major version of cosmiconfig (https://github.com/cosmiconfig/cosmiconfig/blob/main/CHANGELOG.md#900) but since there are more significant breaking changes I elected to suggest v8.

@LironEr
Copy link
Owner

LironEr commented Aug 17, 2024

Thank you for the PR! (:

Please run yarn to update the yarn.lock file

@okize
Copy link
Contributor Author

okize commented Aug 17, 2024

@LironEr ugh, so sorry, I did that after I opened the PR and then forgot to push 🤦‍♂️

There should be no significant breaking changes by upgrading to v8 (https://github.com/cosmiconfig/cosmiconfig/blob/main/CHANGELOG.md#800) it just drops support for older versions of NodeJS.

The benefit to this change will be supporting ESM by default: cosmiconfig/cosmiconfig#224
Copy link

bundlemon bot commented Aug 18, 2024

BundleMon

Unchanged files (14)
Status Path Size Limits
assets/Main-index-(hash).js
461.19KB -
JS files
assets/ReportsChart-(hash).js
360.18KB -
JS files
assets/Table-(hash).js
257.06KB -
JS files
assets/TextField-(hash).js
46.68KB -
JS files
assets/Tabs-(hash).js
38KB -
JS files
assets/index-(hash).js
34.1KB -
JS files
assets/Alert-(hash).js
5.77KB -
JS files
assets/LoadingButton-(hash).js
3.33KB -
JS files
assets/CircularProgress-(hash).js
2.86KB -
JS files
assets/CreateProjectPage-(hash).js
1.38KB -
JS files
assets/LoginPage-(hash).js
1.22KB -
index.html
869B -
JS files
assets/AlertTitle-(hash).js
659B -
JS files
assets/useQueryParams-(hash).js
114B -

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
JS files
**/*.js
1.19MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@LironEr LironEr merged commit 3107bc1 into LironEr:main Aug 18, 2024
9 checks passed
@okize okize deleted the patch-1 branch August 18, 2024 12:32
@okize
Copy link
Contributor Author

okize commented Aug 18, 2024

@LironEr thanks for the quick ship! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants