This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Improve saveAccount utility code #774

Closed

reyraa opened this issue Sep 25, 2017 · 1 comment

Labels

Contributor

reyraa commented Sep 25, 2017

There are some issues with the saveAccount utility worth fixing:

We're creating an array, but actually never adding a new member to it.
We call remove account but we remove entire array. which brings up, why an array then?
none of the methods return a response to the caller.
None of the methods are covered with unit tests.

slaweet added the refactoring label

slaweet changed the title ~~Improve saveAccount utility~~ Improve saveAccount utility code

Contributor

slaweet commented Nov 30, 2017

This was fixed with #966

slaweet closed this as completed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.