Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Disallow lowercase l in address - Closes #1070 #1071

Merged
merged 2 commits into from
May 23, 2018
Merged

Disallow lowercase l in address - Closes #1070 #1071

merged 2 commits into from
May 23, 2018

Conversation

slaweet
Copy link
Contributor

@slaweet slaweet commented May 17, 2018

What was the problem?

Two problems:

  • api call failure was not handled
  • lowercase l in address was allowed

How did I fix it?

  • handled api call failure
  • disabled lowercase l in address

How to test it?

Try to send a transaction to 234235235l

Review checklist

@slaweet slaweet self-assigned this May 17, 2018
@slaweet slaweet requested a review from yasharAyari May 17, 2018 08:56
@slaweet slaweet force-pushed the 1070-disallow-lowercase-address branch from 8836ff5 to fab95cf Compare May 17, 2018 08:59
yasharAyari
yasharAyari approved these changes May 23, 2018
View reviewed changes
Copy link
Contributor

@yasharAyari yasharAyari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yasharAyari yasharAyari merged commit 12ccd0d into 2.0.0 May 23, 2018
@slaweet slaweet deleted the 1070-disallow-lowercase-address branch May 23, 2018 11:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yasharAyari yasharAyari yasharAyari approved these changes

Assignees

@slaweet slaweet

Labels
✅ ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slaweet @yasharAyari