Add selected votes counts bar - Closes #445 #754
Conversation
slaweet
force-pushed
the
445-voting-bar
branch
from
9b5488d
to
5155b7f
Compare
slaweet
added
👁️ pending review
🏗️ in progress
and removed
🏗️ in progress
👁️ pending review
labels
slaweet
force-pushed
the
445-voting-bar
branch
from
fde6742
to
918d54c
Compare
... that shows an error toast if more than 33 delegates selected
slaweet
force-pushed
the
445-voting-bar
branch
from
918d54c
to
9348eb9
Compare
| import style from './votingBar.css'; | ||
|
|
||
| const VotingBar = ({ votes }) => { | ||
| const { maxCountOfVotes, maxCountOfVotesInOneTurn } = votingConst; |
There was a problem hiding this comment.
To prevent verbosity please perform this shorthand assignment while importing
There was a problem hiding this comment.
I wanted to use it like that, but it doesn't work.
import { maxCountOfVotes, maxCountOfVotesInOneTurn } from '../../constants/voting';
ends up in both maxCountOfVotes and maxCountOfVotesInOneTurn being undefined
|
|
||
| const VotingBar = ({ votes }) => { | ||
| const { maxCountOfVotes, maxCountOfVotesInOneTurn } = votingConst; | ||
| const votedList = Object.keys(votes).filter(key => votes[key].confirmed); |
There was a problem hiding this comment.
Please use a single forEach loop instead of 3 filters and file the lists thought the same iteration
There was a problem hiding this comment.
I set up a jsperf to see the difference:
https://jsperf.com/multiple-filters-vs-foreach
ForEach is 3 or 4 times faster, but the absolute values of how long it takes on a list of 100 still make the difference negligible.
I like using filters for their conciseness and readability.
src/store/middlewares/voting.js
Outdated
| const voteCount = Object.keys(votes).filter( | ||
| key => votes[key].confirmed !== votes[key].unconfirmed).length; | ||
| const currentVote = votes[action.data.username] || { unconfirmed: true, confirmed: false }; | ||
| console.log(voteCount, votingConst.maxCountOfVotesInOneTurn, currentVote); |
There was a problem hiding this comment.
Remove console.log. It's interesting that you have a log here and eslint doesn't fail
src/store/middlewares/voting.js
Outdated
| key => votes[key].confirmed !== votes[key].unconfirmed).length; | ||
| const currentVote = votes[action.data.username] || { unconfirmed: true, confirmed: false }; | ||
| console.log(voteCount, votingConst.maxCountOfVotesInOneTurn, currentVote); | ||
| if (voteCount === votingConst.maxCountOfVotesInOneTurn + 1 && |
There was a problem hiding this comment.
Would be great if we show a toast for when we exceed 101 overall votes.
The goal is to add a bar fixed at the bottom of the voting page that displays numbers of votes selected for voting.
I had it previously implemented in Angular and it looked like this:
The original PR was #447
Closes #445