This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Open external URLs on openUrl event - Closes #787 #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyraa
changed the title
yasharAyari
previously approved these changes
Sep 29, 2017
reyraa
changed the title
|
I'd like to tweak this PR to ensure links won't break the routing. Also I'll add an alert message to inform user about the URL invalidity. |
reyraa
force-pushed
the
787-open-url-listener
branch
from
24c89a7
to
9738de3
Compare
slaweet
approved these changes
Oct 2, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in this PR add a listener to openUrl event transmitted from main process.
How to test:
npm run build && npm run startlisk://main/voting/send: should open the send modal in voting tablisk://main/wrong-tab: should show a toaster informing about wrong URLlisk://main/voting/wrong-dialog: open voting tab without any modalslisk://register: should open the register modal in login pageand so on.
Closes #787