Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Enable locale default select in browser and on reload - Closes #897 #904

Merged
merged 3 commits into from
Oct 24, 2017
Merged

Enable locale default select in browser and on reload - Closes #897 #904

merged 3 commits into from
Oct 24, 2017

Conversation

ginacontrino
Copy link
Contributor

What's the problem?

What did you do?

  • Saved locale in localStorage in browser
  • Added an event to make a new request for the locale in electron

@ginacontrino ginacontrino self-assigned this Oct 24, 2017
@ginacontrino ginacontrino changed the base branch from 1.2.0 to development October 24, 2017 08:42
@ginacontrino ginacontrino changed the base branch from development to 1.2.0 October 24, 2017 08:42
slaweet
slaweet approved these changes Oct 24, 2017
View reviewed changes
Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well. Thanks Gina

@ginacontrino ginacontrino merged commit 1f94d9d into 1.2.0 Oct 24, 2017
@ginacontrino ginacontrino deleted the 897-language-setup branch October 24, 2017 09:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@slaweet slaweet slaweet approved these changes

Assignees

@ginacontrino ginacontrino

Labels
✅ ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ginacontrino @slaweet