Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Create pull request template - Closes #939 #940

Merged
merged 1 commit into from
Nov 2, 2017
Merged

Conversation

slaweet
Copy link
Contributor

@slaweet slaweet commented Nov 1, 2017

What was the problem?

We had no pull request template, so our PRs often didn't contain much information.

How did I fix it?

By creating .github/pull_request_template.md that contains this

How to test it?

Appart from merging this PR, I don't know.

Review checklist

  • The PR solves Create pull request template #939
  • All new code is covered with unit tests
  • All new features are covered with e2e tests
  • All new code follows best practices

Copy link
Contributor

@ginacontrino ginacontrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you 👍

@slaweet slaweet merged commit f0d37cb into 1.3.0 Nov 2, 2017
@slaweet slaweet deleted the 939-pr-template branch November 2, 2017 05:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants