This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginacontrino
force-pushed
the
925-testnet-tests
branch
from
November 6, 2017 14:30
3fdaa55
to
f12d4b8
Compare
fchavant
reviewed
Nov 6, 2017
Jenkinsfile
Outdated
@@ -126,6 +126,14 @@ node('lisk-nano') { | |||
Xvfb :1$N -ac -screen 0 1280x1024x24 & | |||
|
|||
# Run end-to-end tests | |||
|
|||
withCredentials([string(credentialsId: 'lisk-nano-testnet-passphrase', variable: 'TESTNET_PASSPHRASE')]) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to move this withCredentials
statement to wrap the whole sh
above, i.e. you need to have:
withCredentials([...]) {
sh '''
[...]
npm run --silent e2e-test:testnet:custom -- --params.baseURL file://$WORKSPACE/app/build/index.html --params.liskCoreURL http://127.0.0.1:400$N --params.testnetPassphrase $TESTNET_PASSPHRASE --params.testnetCustomNode true
[...]
'''
}
[...]
ginacontrino
force-pushed
the
925-testnet-tests
branch
2 times, most recently
from
November 6, 2017 15:38
e6ced3d
to
45241a7
Compare
ginacontrino
force-pushed
the
925-testnet-tests
branch
8 times, most recently
from
November 7, 2017 09:19
0251524
to
955ec6d
Compare
ginacontrino
force-pushed
the
925-testnet-tests
branch
3 times, most recently
from
November 7, 2017 13:36
88a21a1
to
ce4313e
Compare
ginacontrino
force-pushed
the
925-testnet-tests
branch
from
November 7, 2017 13:53
ce4313e
to
f56a4ee
Compare
slaweet
approved these changes
Nov 7, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job Gina
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
We had no configuration for running tests with testnet
How did I fix it?
How to test it?
Before you run the tests, you should save the passphrase in your env
export TESTNET_PASSPHRASE='recipe bomb asset salon coil symbol tiger engine assist pact pumpkin visit'
Then, in order to just run tests with testnet you can go:
npm run e2e-test -- --disableChecks --cucumberOpts.tags=@testnet --params.network=testnet --params.useTestnetPassphrase=true
In order to run tests with the custom node "https://testnet.lisk.io" you can go:
npm run e2e-test -- --disableChecks --cucumberOpts.tags=@testnet -- --params.liskCoreURL=https://testnet.lisk.io --params.useTestnetPassphrase=true
Make also sure that the normal tests still work:
npm run e2e-test
Review checklist