This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Re-enable unit tests after Core 1.0.0 migration - Closes #1072 #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaweet
force-pushed
the
1072-re-enable-unit-tests-after-1-0-0-migration
branch
from
67459af
to
e514232
Compare
yasharAyari
previously approved these changes
May 18, 2018
slaweet
changed the title
slaweet
force-pushed
the
1072-re-enable-unit-tests-after-1-0-0-migration
branch
from
ddcde18
to
d9f29dd
Compare
yasharAyari
approved these changes
May 25, 2018
slaweet
changed the title
12 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Some tests were skipped (see #1072)
How did I fix it?
I re-enabled them
How to test it?
Run the tests, read the tests
Review checklist