Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Setup auto update - Closes #196 #765

Merged
merged 19 commits into from
Nov 20, 2017
Merged

Setup auto update - Closes #196 #765

merged 19 commits into from
Nov 20, 2017

Conversation

slaweet
Copy link
Contributor

@slaweet slaweet commented Sep 22, 2017

What was the problem?

Users stay stayed on older versions without knowing there is a new one.

How did I fix it?

By setting up electron-updater

How to test it?

  • decrease version in app/package.json to 1.2.0
  • build nano with npm run pack (On mac) or npm run pack:win (On Windows)
  • install the built package from 'dist' folder
  • open lisk nano
  • wait for couple seconds
  • there will be an alert like this: screen shot 2017-11-17 at 14 30 13
  • click "Update now"
  • wait for a minute or two for the download (you can use that time to check version in about dialog or log in and check that "encrypt message" feature is present)
  • there will be another alert when the download finishes, confirm it.
  • the app restarts
  • check version in about dialog or log in and check that "encrypt message" feature is no longer present

Review checklist

@slaweet slaweet self-assigned this Sep 22, 2017
@slaweet slaweet force-pushed the 196-auto-update branch 2 times, most recently from af892a4 to 658133d Compare September 22, 2017 13:51
@slaweet slaweet changed the base branch from development to 1.3.0 October 9, 2017 08:45
@slaweet slaweet changed the base branch from 1.3.0 to development October 9, 2017 09:16
@slaweet slaweet changed the base branch from development to 1.3.0 October 9, 2017 09:16
@slaweet slaweet force-pushed the 196-auto-update branch 2 times, most recently from ce7b7d3 to 5b8de7b Compare November 10, 2017 13:28
Copy link
Contributor

@yasharAyari yasharAyari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New version number doesn't exist in update popup message.

@slaweet slaweet force-pushed the 196-auto-update branch 2 times, most recently from 66e8317 to 336f1fe Compare November 17, 2017 12:20
@ginacontrino
Copy link
Contributor

@slaweet when I click on "update", it takes like 30 seconds or more before I get the notification "Updates downloaded, application will be quit for update...". This was quite confusing, because I was wondering if it's updating or not. Usually you get some kind of progress bar or some other kind of notification that something is actually happening.

Also, when I download the app, and I move it to the "Applications", but open it from here:

screen shot 2017-11-17 at 15 10 53

And then click "update", it is not actually updating. I, as a user, often open the app directly from that window, so I can imagine other people doing that as well.

@slaweet slaweet merged commit acd7b83 into 1.3.0 Nov 20, 2017
@slaweet slaweet deleted the 196-auto-update branch November 20, 2017 15:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants