Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Add e2e tests for infinite scroll - Closes #740 #849

Merged
merged 3 commits into from
Oct 11, 2017
Merged

Add e2e tests for infinite scroll - Closes #740 #849

merged 3 commits into from
Oct 11, 2017

Conversation

ginacontrino
Copy link
Contributor

What's the Problem?
There were no tests for the infinite scroll #740

What did you do?

  • Added tests for transactions, voting and forging
  • Changed the bottomOffset to load more transactions -> fixes a failing test

How can I test this?

  • Run the e2e tests
  • Check scrolling still behaves normal in the browser

@ginacontrino ginacontrino self-assigned this Oct 10, 2017
@slaweet slaweet changed the title Addind e2e tests for infinite scroll - Closes #740 Adding e2e tests for infinite scroll - Closes #740 Oct 10, 2017
@slaweet slaweet changed the title Adding e2e tests for infinite scroll - Closes #740 Add e2e tests for infinite scroll - Closes #740 Oct 10, 2017
reyraa
reyraa approved these changes Oct 11, 2017
View reviewed changes
Copy link
Contributor

@reyraa reyraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ginacontrino .

@ginacontrino ginacontrino merged commit 0300a76 into 1.2.0 Oct 11, 2017
@ginacontrino ginacontrino deleted the 740-e2e-infinite-scroll branch October 11, 2017 07:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@reyraa reyraa reyraa approved these changes

Assignees

@ginacontrino ginacontrino

Labels
✅ ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ginacontrino @reyraa