This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 60
Setup launch protocol for voting - Closes #806 #851
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaweet
force-pushed
the
806-launch-protocol-for-voting
branch
from
October 11, 2017 12:12
2c47e4c
to
0be300d
Compare
so that it can be used with "address"
... if it is already in the redux store
slaweet
force-pushed
the
806-launch-protocol-for-voting
branch
2 times, most recently
from
October 11, 2017 14:56
432feb5
to
c2f545e
Compare
slaweet
force-pushed
the
806-launch-protocol-for-voting
branch
from
October 11, 2017 14:57
c2f545e
to
aeb507b
Compare
... to see if it makes them more stable
reyraa
previously approved these changes
Oct 13, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good Vit! Thank you
reyraa
approved these changes
Oct 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is an example for testing with our jenkins build:
https://jenkins.lisk.io/test/lisk-nano/PR-851/#/main/voting/vote?unvotes=genesis_29,standby_20,standby_34&votes=genesis_21,genesis_213,genesis_34,genesis_21,genesis_35,genesis_353,genesis_11,genesis_14,genesis_24,genesis_55,genesis_53
And here for testing locally:
lisk://main/voting/vote?unvotes=genesis_29,standby_20,standby_34&votes=genesis_21,genesis_213,genesis_34,genesis_21,genesis_35,genesis_353,genesis_11,genesis_14,genesis_24,genesis_55,genesis_53
Closes #806