This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Review e2e tests - Closes #973 #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaweet
force-pushed
the
973-review-e2e-tests
branch
from
1a380da
to
1b61e37
Compare
either in unit tests or in other e2e tests
... because there is no menu.feature anymore
slaweet
force-pushed
the
973-review-e2e-tests
branch
from
1b61e37
to
96d7555
Compare
yasharAyari
approved these changes
Nov 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Lisk Nano had unnecessary e2e tests
How did I fix it?
By revising and reducing e2e tests
How to test it?
Run e2e tests, check the changes
Review checklist