[BUG] 404 Error page responds with 200 HTTP code

[sambartik]

Environment

Self-Hosted (Docker)

System

No response

Version

2.1.1

Describe the problem

Hello, I have been using dashy for a while now. I have configured my own logic for 404 error pages via nginx. Today I have noticed that instead of my own logic I got shown the new native Dashy's 404 error page.

In my configuration, the Dashy is behind a reverse proxy that handles the traffic. I have my own way of handling when Dashy would return a 404 error. However, now it fails, because Dashy returns /404 page with an HTTP 200 OK status.

Reverting back to version 2.1.0 fixed the issue.

Additional info

No response

Please tick the boxes

• You have explained the issue clearly, and included all relevant info
• You are using a supported version of Dashy
• You've checked that this issue hasn't already been raised
• You've checked the docs and troubleshooting guide
• You agree to the code of conduct

[liss-bot]

If you're enjoying Dashy, consider dropping us a ⭐
_{🤖 I'm a bot, and this message was automated}

[liss-bot]

This issue has gone 6 weeks without an update. To keep the ticket open, please indicate that it is still relevant in a comment below. Otherwise it will be closed in 5 working days.

[liss-bot]

This issue was automatically closed because it has been stalled for over 6 weeks with no activity.

[shellshock1953]

Same here - can we reopen this one?

[Lissy93]

I'm actually not sure that this ever worked.

Reason being, in Vue all the routing is handled on the client side, so the server serves up the same file whatever route you visit (it's always index.html), which then renders whatever it needs (or a "not found" message if nothing matches).

That said, I can implement logic in the Node server to respond with a 404 status when the index.html itself is not found.

If this used to work for you, could it have been a change that you made in your reverse proxy config?

[liss-bot]

The fix for this issue has now been released in 2.1.2 ✨

If you haven't done so already, please update your instance to 2.1.2 or later. See 2.1.2 for full info.

Feel free to reach out if you need any more support. If you are enjoying Dashy, consider supporting the project.