-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Pages unable to pull remote server config. #1695
Comments
I did a random test using the endpoint So I am thinking there is nothing wrong with the proxy settings, and this is a dashy issue. |
The error message from the browser console says it did not fetch the remote resource at all as the page that was requesting the resource and the resource are from different origins. Browsers check the While using https you need proper configuration of CORS. |
@hockwill So dashy is behind Nginx Proxy Manager. What I do not understand is if you go to the URL with curl or a web browser it absolutely loads the conf.yml file for you. But when another dashy instance tries it it does not work, only Dashy complains but no other browser, curl, or wget has an issue. Additionally I do not understand why testing with the sample https://dashy.to/docs/pages-and-sections/ using the If this was really a CORS issue, than shouldn't every browser and CLI tool be erroring out as well? It seems very poor to think that an application has to make the specific check but everyone else can access it. |
I am getting different results with different browsers using the
After some searching about for why this was. I had Firefox clear the site data for my test Dashy and it worked. CORS is handled in the browser when one site tries to include resources from another. Fetching a single item with curl does not trigger CORS. |
Sorry for loonnnng time away. So if I understand you correctly this is a browser issue? During this time I migrated services off nginx proxy manager and moved to Caddy.
So while previously I checked with curl and things worked I checked again and still failure. I get the same error, "Unable to load config from: https://snippet.host/tvcw/raw I tried this in multiple browsers. (Chrome, Safari, Opera) After some more testing, it appears that the issue may be related to Dashy's handling of authenticated pages. I verified this by starting an incognito window with RAW working, and with the destination behind a basic |
Yes CORS is a browser/https thing. The https server hosting the config files it the one that needs to provide the headers. I poked about to make my own instance load a config file from a basicauth https host. |
@hockwill ... So when using basicauth, the Access-Control-Allow-* methods need to be manually populated to specific hosts? This is super odd still because if I take the same URL string put into dashy with the basicauth added to the URL, and placed into ANY browser it instantly connects and gives the conf. No needing to modify anything in the server side or client side. It only seems to fail when dashy makes the request specifically. If you look at the headers from a chrome session using the same connection string, you can see it clearly loads without any issues. And NONE of those headers are required. If in fact the "Browser" required the Access-Control-Access-* headers than it should have errored which it does not. It simply does as expected and is to load the content. |
https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS I do not use Caddy anywhere can cannot provide header setups for it. |
Environment
Self-Hosted (Docker)
System
docker
Version
current
Describe the problem
Trying to add a page from a remote dashy install, unfortunately it errors out. with the dialog
Looking at the browser console, I get this error, however....
The remote dashy is protected by HTTP Basic handled by Nginx Proxy Manager (NPM). When I tried passing the credentials in the url
https://username:password@dashy.DOMAIN.COM/conf.yml
from an unauthenticated browser it works fine no problem.The above curl was ran from the local docker server running dashy.
Additional info
No response
Please tick the boxes
The text was updated successfully, but these errors were encountered: