Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] appConfig undefiend in router.js #688

Closed
BaconFox opened this issue Jun 1, 2022 · 2 comments
Closed

[BUG] appConfig undefiend in router.js #688

BaconFox opened this issue Jun 1, 2022 · 2 comments

Comments

@BaconFox
Copy link

BaconFox commented Jun 1, 2022

I'm just getting started with Dashy and had the super basic starting config from Section 3 of quick-start.md. Dashy loaded fine but I never got a chance to dive into the config. I then updated the image to the latest (2.0.9) and found the container would start without error, but Dashy would not load in the browser (Firefox 100).

I noticed the following in the console:

Uncaught TypeError: _a.appConfig is undefined
    41cb router.js:107
    Webpack 8

I do not have appConfig defined in my config.yml, but the docs lead me to believe that should not be necessary.

As long as I define any property in appConfig, even an invalid one such as:

pageInfo:
  title: Home Lab
appConfig:
   someDef: someValue
sections: # An array of sections
- name: Example Section
<snip>

Dashy will load correctly.

Perhaps router.js:107 should be re-written to accept appConfig being undefined or perhaps the default value should be defined earlier for users getting started with very basic configs such as myself?

@liss-bot

This comment was marked as outdated.

@liss-bot liss-bot closed this as completed Jun 1, 2022
@BaconFox BaconFox changed the title appConfig undefiend in router.js [BUG] appConfig undefiend in router.js Jun 1, 2022
@Lissy93 Lissy93 reopened this Jun 1, 2022
@Lissy93
Copy link
Owner

Lissy93 commented Jun 1, 2022

Heya @synmoo

Thanks for raising this, and for the clear description, apologies for the issue.
It is indeed a bug, was also recently raised in #682 and I've got a fix ready for it in bc43caa of #685, which I will get merged ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants