From f620a95efaa7104af84ae3a623fd826338c95ccd Mon Sep 17 00:00:00 2001
From: Chase Payne <chase_payne@outlook.com>
Date: Sat, 14 Sep 2024 15:55:41 -0500
Subject: [PATCH] make sonarcloud happy again

---
 src/platform/windows/display_base.cpp | 2 +-
 tools/ddprobe.cpp                     | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/platform/windows/display_base.cpp b/src/platform/windows/display_base.cpp
index 85d321cfc7..7058b77b68 100644
--- a/src/platform/windows/display_base.cpp
+++ b/src/platform/windows/display_base.cpp
@@ -368,7 +368,7 @@ namespace platf::dxgi {
       std::vector<std::string> args = { std::to_string(i), display_name };
       try {
         if (verify_frame_capture) {
-          args.push_back("--verify-frame-capture");
+          args.emplace_back("--verify-frame-capture");
         }
         result = bp::system(cmd, bp::args(args), bp::std_out > bp::null, bp::std_err > bp::null);
       }
diff --git a/tools/ddprobe.cpp b/tools/ddprobe.cpp
index f33f7517d2..3c2eb05716 100644
--- a/tools/ddprobe.cpp
+++ b/tools/ddprobe.cpp
@@ -86,14 +86,14 @@ syncThreadDesktop() {
   */
 bool
 is_valid_frame(const D3D11_MAPPED_SUBRESOURCE &mappedResource, const D3D11_TEXTURE2D_DESC &frameDesc, float darknessThreshold = 0.1f) {
-  const uint8_t *pixels = static_cast<const uint8_t *>(mappedResource.pData);
+  const auto *pixels = static_cast<const uint8_t *>(mappedResource.pData);
   const int bytesPerPixel = 4;  // (8 bits per channel, excluding alpha). Factoring HDR is not needed because it doesn't cause black levels to raise enough to be a concern.
   const int stride = mappedResource.RowPitch;
   const int width = frameDesc.Width;
   const int height = frameDesc.Height;
 
   // Convert the darkness threshold to an integer value for comparison
-  const int threshold = static_cast<int>(darknessThreshold * 255);
+  const auto threshold = static_cast<int>(darknessThreshold * 255);
 
   // Iterate over each pixel in the frame
   for (int y = 0; y < height; ++y) {