Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AvoidInfo Lifetime Manager #23

Open
3 tasks done
TheManta opened this issue Jul 27, 2022 · 0 comments
Open
3 tasks done

Add AvoidInfo Lifetime Manager #23

TheManta opened this issue Jul 27, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@TheManta
Copy link
Collaborator

Game Version

Global

Feature Description

RB's built-in AvoidanceManager lets us draw custom avoids but expects us to manage their lifetimes ourselves. After drawing an avoid and getting its AvoidInfo, an Avoid will be created by AvoidanceManager whenever canRun is true and destroyed when false. The struggle is the AvoidInfos will never be destroyed, which is cool if you want that AOE to recur but can unexpectedly stack up AvoidInfos for the same purpose -- they even persist through stop/start!

We need a lifetime manager to sanely clean up the AvoidInfos we draw manually. AvoidanceManager.Remove(AvoidInfo) and .RemoveAll(AvoidInfo => bool) are relevant here. This will probably tie into our AvoidanceHelpers as part of a larger avoidance system abstraction.

Other Information

  • This issue is a feature request, not a bug or question.
  • RebornBuddy and all add-ons have been updated to latest.
  • No identifying information (e.g., character name) is being submitted.
@TheManta TheManta added the enhancement New feature or request label Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant