Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to unwrapping/wrapping for trajectory processing in the BilayerAnalyzer class. #25

Open
blakeaw opened this issue Mar 12, 2018 · 3 comments
Labels
enhancement Request or suggestion for an enhancement to current features or api.

Comments

@blakeaw
Copy link
Collaborator

blakeaw commented Mar 12, 2018

The BilayerAnalyzer class assumes that the coordinates of the input trajectory are wrapped by atom and therefore automatically unwraps the coordinates by atom. This can fail when the first frame is not a good reference for unwrapping. This needs to be upgraded to allow for more options of processing the trajectory, such as the opposite scenario where the input trajectory is unwrapped and needs to be wrapped. It would also be good to allow the user to be able to turn off wrapping/unwrapping.
For the currently assumed case (atom-wise wrapped coordinates), it would probably be good to add in a separate input setting for a reference structure; this could default to the first frame when unwrapping used.

A possible long term solution might be to add a transformations protocol (e.g wrapping/unwrapping, structure alignment) that can be set by the user (with proper defaults and conflict resolution based on the analyses being implemented) that is similar to the suggestion in MDAnalysis/mdanalysis#786

@blakeaw blakeaw added the enhancement Request or suggestion for an enhancement to current features or api. label Mar 12, 2018
@kain88-de
Copy link

Hi

A GSoC Student is implementing an on-the-fly transformation protocol in MDAnalysis directly this summer. His own use case are membrane simulations as well. You can find more information on our blog or drop us a line on the mdanalysis devel mailing list.

@blakeaw
Copy link
Collaborator Author

blakeaw commented May 21, 2018

@kain88-de Okay, cool. Thanks for the heads up.

@kain88-de
Copy link

The first PR of the project is here

MDAnalysis/mdanalysis#1902

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request or suggestion for an enhancement to current features or api.
Projects
None yet
Development

No branches or pull requests

2 participants