Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #24: retain image position on coming back to edit again. #37

Merged
merged 1 commit into from
Oct 1, 2021
Merged

Fix issue #24: retain image position on coming back to edit again. #37

merged 1 commit into from
Oct 1, 2021

Conversation

anoopmsivadas
Copy link
Contributor

@anoopmsivadas anoopmsivadas commented Oct 1, 2021 •
edited
Loading

Add position state for React Avatar Editor to retain the image position even after going back to edit again.
Fixes #24

@abhir9 abhir9 added hacktoberfest contribution in hacktoberfest hacktoberfest-accepted labels Oct 1, 2021
@abhir9 abhir9 self-assigned this Oct 1, 2021
@abhir9 abhir9 merged commit e9aa00d into LoginRadius:master Oct 1, 2021
@abhir9
Copy link
Contributor

abhir9 commented Oct 1, 2021

@anoopmsivadas Your PR merged

Thanks for your contribution
don't forget to star the repo

apart from this, offering you swags from loginradius , please fill this form
https://docs.google.com/forms/d/e/1FAIpQLSfnwWUWlRRwZpgmOX7X8lGMKotLbVe1JXCjPFSahLxLWugwig/viewform

@pareek-naren
Copy link

@anoopmsivadas
We are going to feature our top contributors on the LoignRadius social media platform.
If you are interested, please share your LinkedIn, Twitter Profile along with the image you wanted to display.

@anoopmsivadas
Copy link
Contributor Author

@pareek-narendra where should I share those?

@abhir9
Copy link
Contributor

abhir9 commented Oct 11, 2021

@anoopmsivadas you can share here .

@anoopmsivadas
Copy link
Contributor Author

Ok,
LinkedIn: https://www.linkedin.com/in/anoopmsivadas/
twitter: https://twitter.com/anoopmsivadas
image: https://twitter.com/AnoopMSivadas/photo (hope this one is fine.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhir9 abhir9 abhir9 approved these changes

Assignees

@abhir9 abhir9

Labels
hacktoberfest contribution in hacktoberfest hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Dragging image position reverts to original while coming back to edit again
3 participants
@anoopmsivadas @abhir9 @pareek-naren