Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on click "copy" will contains base64 copy of images, wide range of characters. #4

Open
abhir9 opened this issue Sep 25, 2020 · 9 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@abhir9
Copy link
Contributor

abhir9 commented Sep 25, 2020

on click "copy" will contains base64 copy of images ,
which might be an issue with some email provider to not allow set as a signature (due to having more character then limit). try with gmail, go to setting to update signature it will block

@abhir9 abhir9 added enhancement New feature or request help wanted Extra attention is needed hacktoberfest contribution in hacktoberfest labels Sep 25, 2020
@rafaeelaudibert
Copy link

@abhir9 What should be the behavior then? If you could clarify it, I could tackle this issue!

@abhir9
Copy link
Contributor Author

abhir9 commented Oct 4, 2020

@rafaeelaudibert i am still not sure , what would the best way , still figuring this out , if you have any better idea , let me know

@arc9693
Copy link
Contributor

arc9693 commented Oct 5, 2020

@abhir9

  1. We can use an HTML compressor that could compress the code before it is copied. Maybe use this.
  2. How about having an image server so that all the uploaded files could lie there. And then we don't need to have a base64 formatted image. Just the link to the image should be enough.

What are your thoughts on these ideas?
I would like to work on this.

@abhir9 abhir9 changed the title on click "copy" will contains base64 copy of images, wide range of characters. on click "copy" will contains base64 copy of images, wide range of characters. Sep 24, 2021
@abhir9
Copy link
Contributor Author

abhir9 commented Sep 27, 2021

@arc9693 sorry for late reply, we don't want to maintain a additional image server, too keep the cost low and less dependent .

still if you want to contribute i can assign it you.

@AmreshSinha
Copy link

Instead of giving them a single result with image, we can give the client 2 results, one with base64 image (like for gmail) and one without any image (or a gravatar).

@abhir9
Copy link
Contributor Author

abhir9 commented Sep 30, 2021

@AmreshSinha if user do not upload any image or profile picture it will be without image (gravtar)
so finally it will be one only

@AmreshSinha
Copy link

@abhir9
If I don't upload any profile pic, then I am getting this:
image

And its base64 image URL.

We can replace the default image with user's initials image with the help of UI-Avatars Service.
https://ui-avatars.com/

Example:
https://ui-avatars.com/api/?name=Amresh+Sinha&background=000&color=fff&rounded=true
Example Avatar

@AmreshSinha
Copy link

AmreshSinha commented Oct 1, 2021

So finally what can be the solution?

  1. Uploading to Image server
  2. or giving one more result pane without their profile image. (i.e. with UI avatars) (which bydefault should be there too) {This will be a proper image URL and not a base64 url)

What do you suggest @abhir9 ?

@AmreshSinha
Copy link

AmreshSinha commented Oct 4, 2021

Bump (Sorry for the bump but I want to know what is the final resolution which is good for this issue) @abhir9

@abhir9 abhir9 removed the hacktoberfest contribution in hacktoberfest label Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants