Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

u32x8 compare methods implemented as functions and not as traits #85

Open
RazrFalcon opened this issue Jan 24, 2021 · 6 comments
Open

Comments

@RazrFalcon
Copy link
Contributor

No description provided.

@Lokathor
Copy link
Owner

say what now?

@RazrFalcon
Copy link
Contributor Author

pub fn cmp_eq(self, rhs: Self) -> Self {

pub fn cmp_eq(self, rhs: Self) -> Self {

@Lokathor
Copy link
Owner

Oh. but it looks like those methods also exist in the latest of the main branch? And in the published 0.6.4 version.

Where are you not seeing them available?

@RazrFalcon
Copy link
Contributor Author

Yes, they exist. But in f32x8 they are implemented as traits, not as methods.

@Lokathor
Copy link
Owner

Oh, that, yeah. If you want to have the trait option just make a PR for trait impls that call the method. We can get that published real quick.

@RazrFalcon
Copy link
Contributor Author

No, I don't actually use them. Just noticed this issue while was reading the code. It can be fixed at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants