Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NPM dependencies to latest, and fix them (OSOE-671) #67

Closed
Piedone opened this issue Aug 14, 2023 · 3 comments · Fixed by #68
Closed

Update NPM dependencies to latest, and fix them (OSOE-671) #67

Piedone opened this issue Aug 14, 2023 · 3 comments · Fixed by #68
Assignees

Comments

@Piedone
Copy link
Member

Piedone commented Aug 14, 2023

Update all the NPM dependencies of the package to the latest versions, and make sure that the version numbers are not open but fixed to a specific version to avoid issues like Lombiq/Orchard-Base-Theme#84.

Note that updating sass to v1.65.1 causes this issue: Lombiq/Orchard-Base-Theme#84. If Bootstrap has a fix (twbs/bootstrap#39028) and we can update it in Base Theme, then do that; otherwise, keep sass on the latest still compatible version.

Jira issue

@github-actions github-actions bot changed the title Update NPM dependencies to latest, and fix them Update NPM dependencies to latest, and fix them (OSOE-671) Aug 14, 2023
@wAsnk
Copy link
Member

wAsnk commented Aug 24, 2023

Updating stylelint to 15.10.3 from 14.14.0 would mean a major update that contains the following (breaking) changes:
https://stylelint.io/migration-guide/to-15

To sum up, they deprecated 76 rules because they are mostly styling related rules that can be achieved by pretty printers like Prettier so they won't support it anymore from the next major update.

Edit
These are the rules that we are using and deprecated:

'declaration-block-semicolon-newline-before': 'never-multi-line',
'function-comma-newline-after': 'always-multi-line',
'indentation': 4,
'max-line-length': 150,
'selector-list-comma-space-after': 'always-single-line',
'selector-list-comma-newline-after': 'always-multi-line',
'value-list-comma-newline-before': 'never-multi-line'

What should be done in this case?

@Piedone
Copy link
Member Author

Piedone commented Aug 24, 2023

Eh, thanks for looking into this. Let's update to the latest 14.x for now then, and later we can look into upgrading to 15.x and see whether we should use Prettier or something.

@wAsnk
Copy link
Member

wAsnk commented Aug 25, 2023

Alright, then the stylelint-config-standard-scss package max version can be 6.1.0, because the next version (7.0.0) requires stylelint 15.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants