Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Vue.js v3 (OSOE-338) #38

Closed
Piedone opened this issue Mar 21, 2022 · 6 comments · Fixed by #122
Closed

Upgrade to Vue.js v3 (OSOE-338) #38

Piedone opened this issue Mar 21, 2022 · 6 comments · Fixed by #122
Assignees
Labels
enhancement New feature or request

Comments

@Piedone
Copy link
Member

Piedone commented Mar 21, 2022

Once Orchard does that too, see: OrchardCMS/OrchardCore#7110

Also see the official migration guide.

Jira issue

@Piedone Piedone added the enhancement New feature or request label Mar 21, 2022
@github-actions github-actions bot changed the title Upgrade to Vue.js v3 Upgrade to Vue.js v3 (OSOE-338) Sep 18, 2022
@Piedone
Copy link
Member Author

Piedone commented Jan 18, 2024

Can't we feasibly do this without waiting for OC @sarahelsaig?

@sarahelsaig
Copy link
Member

sarahelsaig commented Jan 18, 2024

I think it's possible. The thing to avoid is importing Vue2 and Vue3 on the same page the old fashioned way, because both export the Vue global variable. If the app is instantiated from our <vue-component-app> tag helper then we turns its script into an ES module so Vue is imported locally to the module instead of globally. We can also write a migration guide on how to do the same for those who can't use the tag helper.

btw you linked the migration guide for VueX. Here is the official migration guide for Vue: https://v3-migration.vuejs.org/

@Piedone
Copy link
Member Author

Piedone commented Jan 18, 2024

OK then, thank you. On the frontend, this should not be an issue.

Because this might be necessary for a project of ours soon.

@sarahelsaig
Copy link
Member

How soon? I'd gladly take on this issue. So if you have a rough idea when it will be needed I can plan accordingly.

@Piedone
Copy link
Member Author

Piedone commented Jan 21, 2024

Actually, this might be needed ASAP, I'll share some non-public details privately.

@Piedone
Copy link
Member Author

Piedone commented Jan 28, 2024

Also, we should check if we still need VueContentSecurityPolicyProvider after this upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants