Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: alignment on calendar and header #109

Merged
merged 5 commits into from
Feb 26, 2024
Merged

feat: alignment on calendar and header #109

merged 5 commits into from
Feb 26, 2024

Conversation

DereC4
Copy link
Member

@DereC4 DereC4 commented Feb 25, 2024

No description provided.

@vinsonzheng499
Copy link
Contributor

Looks good.

Copy link
Collaborator

@doprz doprz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Can you provide some sample images as this PR is UI-based please? For future reference always write a brief summary of changes for PRs.

@DereC4
Copy link
Member Author

DereC4 commented Feb 26, 2024

image

@DereC4
Copy link
Member Author

DereC4 commented Feb 26, 2024

I'll find one for the "before" comparison

@DereC4
Copy link
Member Author

DereC4 commented Feb 26, 2024

image

(Adding the divider made me realize how off center it was)

@DereC4 DereC4 requested a review from doprz February 26, 2024 00:51
Copy link
Collaborator

@doprz doprz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@doprz doprz merged commit 8a62d58 into hackathon Feb 26, 2024
5 of 9 checks passed
@doprz doprz deleted the derek/align-2 branch February 26, 2024 01:12
@DereC4
Copy link
Member Author

DereC4 commented Feb 26, 2024

ty

doprz pushed a commit that referenced this pull request Mar 6, 2024
* feat: corrected date updated text

* feat: whew alignment looks way better

* feat: aligned the bars and made the latter half justify-end

* fix: limt

* fix: removed broken divider vinson did u do this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants