Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Schedule Switching Bugs #138

Merged
merged 5 commits into from
Mar 10, 2024
Merged

fix: Schedule Switching Bugs #138

merged 5 commits into from
Mar 10, 2024

Conversation

Lukas-Zenick
Copy link
Collaborator

@Lukas-Zenick Lukas-Zenick commented Mar 9, 2024 •
edited
Loading

Fixes a course popup styling bug as well as some lag issues

@Lukas-Zenick Lukas-Zenick marked this pull request as draft March 9, 2024 21:57
@Lukas-Zenick Lukas-Zenick changed the title style: course selection fix fix: Schedule Switching Bugs Mar 9, 2024
@Lukas-Zenick Lukas-Zenick marked this pull request as ready for review March 9, 2024 22:08
@knownotunknown
Copy link
Contributor

Yo Lukas, what do your changes to useSchedules do? I actually made my own changes, and all I did was change the order of where the state variables were updated.

@Lukas-Zenick
Copy link
Collaborator Author

@knownotunknown
The main fix I believe is that it removes activeIndex and setActiveIndex from the dependencies to run which I think removes some unnecessary hook invocations. It definitely fixes the lag issue though

@Lukas-Zenick Lukas-Zenick requested a review from doprz March 9, 2024 23:01
@doprz doprz merged commit c51e688 into main Mar 10, 2024
10 checks passed
@doprz doprz deleted the course-selection-style branch March 10, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doprz doprz doprz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lukas-Zenick @knownotunknown @doprz