feat: calendar-course-cell-color-picker #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
incredible work (UI-wise) |
doprz
requested changes
Mar 14, 2024
src/views/components/calendar/CalendarCourseCellColorPicker/ColorPatch.tsx
Outdated
Show resolved
Hide resolved
src/views/components/calendar/CalendarCourseCellColorPicker/CourseCellColorPicker.tsx
Outdated
Show resolved
Hide resolved
src/views/components/calendar/CalendarCourseCellColorPicker/CourseCellColorPicker.tsx
Outdated
Show resolved
Hide resolved
src/views/components/calendar/CalendarCourseCellColorPicker/CourseCellColorPicker.tsx
Outdated
Show resolved
Hide resolved
src/views/components/calendar/CalendarCourseCellColorPicker/HexColorEditor.tsx
Outdated
Show resolved
Hide resolved
src/views/components/calendar/CalendarCourseCellColorPicker/HexColorEditor.tsx
Outdated
Show resolved
Hide resolved
src/views/components/calendar/CalendarCourseCellColorPicker/HuePicker.tsx
Outdated
Show resolved
Hide resolved
src/views/components/calendar/CalendarCourseCellColorPicker/HuePicker.tsx
Outdated
Show resolved
Hide resolved
src/views/components/calendar/CalendarCourseCellColorPicker/HuePicker.tsx
Outdated
Show resolved
Hide resolved
|
Also thank you for such a clean PR and adding a demo! |
Razboy20
requested changes
Mar 16, 2024
src/views/components/calendar/CalendarCourseCellColorPicker/CourseCellColorPicker.tsx
Outdated
Show resolved
Hide resolved
src/views/components/calendar/CalendarCourseCellColorPicker/CourseCellColorPicker.tsx
Outdated
Show resolved
Hide resolved
Razboy20
approved these changes
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TAKE 2
This is the color picker component for the calendar view that allows users to set custom colors for their course schedules.
Demo
Basic hover functionality
Selecting a base color
Selecting a shade color
Hex Editor
If a use enters a hex code that exists on the picker (whether is a base color or a shade), the picker selects the appropriate base and shade color.