Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: course color generation #179

Merged
merged 10 commits into from
Mar 19, 2024
Merged

feat: course color generation #179

merged 10 commits into from
Mar 19, 2024

Conversation

Razboy20
Copy link
Member

No description provided.

@doprz doprz self-requested a review March 19, 2024 02:55
Copy link
Collaborator

@doprz doprz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good to me; approved!

Copy link
Collaborator

@doprz doprz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix TS Errors

.eslintrc.cjs Outdated Show resolved Hide resolved
Copy link
Collaborator

@doprz doprz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

src/shared/types/Color.ts Show resolved Hide resolved
src/shared/util/colors.ts Show resolved Hide resolved
src/shared/util/tests/themeColors.test.ts Show resolved Hide resolved
@doprz doprz merged commit 5ed81e4 into main Mar 19, 2024
11 checks passed
@doprz doprz deleted the feat/course-colors branch March 19, 2024 23:54
caseycharleston pushed a commit to caseycharleston/UT-Registration-Plus that referenced this pull request Mar 30, 2024
* feat: course color generation

* feat: add proper TS for hex colors

* refactor: fix oklab and improve contrast ratios

* fix: update HexColor type

* refactor: update color switch point

* refactor: color-related functions and types

* fix: imports and TS issues

* fix: imports and TS issues

* chore: add no-restricted-syntax ForInStatement

* chore(docs): add jsdoc

---------

Co-authored-by: doprz <52579214+doprz@users.noreply.github.com>
caseycharleston pushed a commit to caseycharleston/UT-Registration-Plus that referenced this pull request Mar 30, 2024
* feat: course color generation

* feat: add proper TS for hex colors

* refactor: fix oklab and improve contrast ratios

* fix: update HexColor type

* refactor: update color switch point

* refactor: color-related functions and types

* fix: imports and TS issues

* fix: imports and TS issues

* chore: add no-restricted-syntax ForInStatement

* chore(docs): add jsdoc

---------

Co-authored-by: doprz <52579214+doprz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants