fix: Sum courses for same semester but different unique #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doprz
approved these changes
Mar 26, 2024
Samathingamajig
deleted the
sgunter/fix-sum-courses-for-same-semester-but-different-unique
branch
caseycharleston
pushed a commit
to caseycharleston/UT-Registration-Plus
that referenced
this pull request
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally part of #191, then wasn't included when it was kinda weirdly manually merged into #163
Anyways, this PR just kinda copies over the logic from the aggregate part so that, when looking at individual semesters, it properly sums all the sections that happened during that semester instead of just the first one.
Before: C S 314 Grades Spring 2023
After: C S 314 Grades Spring 2023 (same thing)
This change is