Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: additional changes to #201 #224

Merged
merged 14 commits into from
May 27, 2024

Conversation

DereC4
Copy link
Member

@DereC4 DereC4 commented May 22, 2024

#201


This change is Reviewable

Copy link
Member

@IsaDavRod IsaDavRod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, exactly what I want for weight

@DereC4 DereC4 requested review from Razboy20 and doprz May 22, 2024 03:21
@DereC4 DereC4 marked this pull request as ready for review May 22, 2024 03:34
@DereC4 DereC4 added ready-for-review feature UI/UX-figma PRs that fulfill a task on the UI/UX & Feature Roadmap labels May 22, 2024
src/views/components/calendar/CalenderHeader.tsx Outdated Show resolved Hide resolved
src/views/styles/colors.module.scss Outdated Show resolved Hide resolved
src/stories/components/LogoIcon.stories.tsx Outdated Show resolved Hide resolved
src/stories/components/LogoIcon.stories.tsx Outdated Show resolved Hide resolved
src/stories/components/LogoIcon.stories.tsx Outdated Show resolved Hide resolved
src/stories/components/LogoIcon.stories.tsx Outdated Show resolved Hide resolved
src/stories/components/LogoIcon.stories.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@doprz doprz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you update pnpm-lock.yaml if you didn't update deps?

@DereC4
Copy link
Member Author

DereC4 commented May 24, 2024

Why did you update pnpm-lock.yaml if you didn't update deps?

it must have been included for some reason idk

should i start gitignoring it?

@DereC4
Copy link
Member Author

DereC4 commented May 26, 2024

pnpm-lock.yaml has been TRANSFIGURED BACK TO NORMAL

merge ;-;

@DereC4
Copy link
Member Author

DereC4 commented May 26, 2024

oops

@DereC4
Copy link
Member Author

DereC4 commented May 26, 2024

THE CODE IS CLEAN. I REPEAT, WE ARE SAFE.

Copy link
Collaborator

@doprz doprz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @DereC4 for the PR and addressing the requested changes.

LGTM!

@doprz doprz dismissed Razboy20’s stale review May 27, 2024 14:32

Requested changes were addressed.

@doprz doprz merged commit bc354f3 into Longhorn-Developers:main May 27, 2024
6 checks passed
@DereC4
Copy link
Member Author

DereC4 commented May 27, 2024

we're making it out of texas heat with this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ready-for-review UI/UX-figma PRs that fulfill a task on the UI/UX & Feature Roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants