-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: added descending sort for commits on contributor section in settings page #363 #365
fix: added descending sort for commits on contributor section in settings page #363 #365
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
at some point we need something better than just pulling from the github API on every settings page open, but that's out of scope for this PR |
awaiting response from @IsaDavRod for the question
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, but can this also sort the LONGHORN_DEVELOPERS_SWE before the map?
The admin section at the top should still be based entirely on the order of the file, and LD SWE's should still be above any non-LD contributor, but the SWEs should also be sorted amongst themselves
Added sorting to LONGHORN_DEVELOPERS_SWE. Please ignore the third commit lol. I was working on another issue and accidentally committed WIP changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add descending sort by commits for contributors on the settings page.
Huly®: UTRP-349
This change is