Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Calendar Components 3rd Attempt at Merging #60

Merged
merged 12 commits into from
Feb 3, 2024

Conversation

DereC4
Copy link
Member

@DereC4 DereC4 commented Jan 31, 2024

PLEASE

@DereC4 DereC4 changed the title Calendar Components 3rd Attempt at Merging feat: Calendar Components 3rd Attempt at Merging Jan 31, 2024
Copy link
Collaborator

@sghsri sghsri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good first pass, added some comments on improvements!

Can you also use storybook to develop these components? It helps us with documentation!

Copy link
Collaborator

@doprz doprz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR and thanks for the contribution!

src/stories/components/CalendarGrid.stories.tsx Outdated Show resolved Hide resolved
@sghsri sghsri merged commit ab2cd68 into Longhorn-Developers:main Feb 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants