Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf improvements #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Perf improvements #7

wants to merge 1 commit into from

Conversation

drwestco
Copy link

@drwestco drwestco commented May 3, 2021

For large JSON snippets, use of innerHTML is a huge perf sink. Item count + link content is plain text, so it's significantly faster to createTextNode/appendChild.

For large JSON snippets, use of innerHTML is a huge perf sink. Item count + link content is plain text, so it's significantly faster to createTextNode/appendChild.
@Pheil
Copy link

Pheil commented Dec 15, 2022

Instead of itemsCount.appendChild(document.createTextNode(_getItemsTitle(count))); would it be easier to just use itemsCount.textContent = this._getItemsTitle(count);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants