LA915 region not supported

[anacforcelli]

I am working from Brazil and have been struggling for a while to make my company's custom board work on our LoRaWAN network (hosted by American Tower).

Recently I found out that the AU915 localization, whilst similar to LA915 specification, does not work seamlessly and there is a lot of packet loss that may be due to different RX/TX window differences.

I am attempting to change the parameters as of now and may report later today. If successful, a PR will be submitted. Otherwise, I will return for help.

Thanks in advance!

[danak6jq]

Is this a request to support the LA915 region not found in the LoRaWAN Regional Parameters specs?

[anacforcelli]

yes, I'm trying to do this but somehow it does not compile correctly, maybe i'm doing something wrong with the configs...

[danak6jq]

What build errors are you seeing? (@mluis1 might convert this to a discussion )

[anacforcelli]

This is what i get with current modifications, which I basically did grep -r AU915 and added a code block for LA915 for every file that mentioned it, then copied RegionAU915.h/.c to RegionLA915.h/.c and ctrl-f rename everything.

(.venv) [ana@archlinux pulga]$ west build --pristine=always -b pulga pulga-zephyr/samples/lorawan-class-a-abp/
-- west build: making build dir /home/ana/pulga/build pristine
-- west build: generating a build system
Loading Zephyr default modules (Zephyr base).
-- Application: /home/ana/pulga/pulga-zephyr/samples/lorawan-class-a-abp
-- CMake version: 3.30.3
-- Found Python3: /home/ana/pulga/.venv/bin/python (found suitable version "3.12.5", minimum required is "3.8") found components: Interpreter
-- Cache files will be written to: /home/ana/.cache/zephyr
-- Zephyr version: 3.7.99 (/home/ana/pulga/zephyr)
-- Found west (found suitable version "1.2.0", minimum required is "0.14.0")
-- Board: pulga, qualifiers: nrf52840
-- Shield(s): pulga-lora
-- ZEPHYR_TOOLCHAIN_VARIANT not set, trying to locate Zephyr SDK
-- Found host-tools: zephyr 0.16.8 (/opt/zephyr-sdk-0.16.8)
-- Found toolchain: zephyr 0.16.8 (/opt/zephyr-sdk-0.16.8)
-- Found Dtc: /opt/zephyr-sdk-0.16.8/sysroots/x86_64-pokysdk-linux/usr/bin/dtc (found suitable version "1.6.0", minimum required is "1.4.6")
-- Found BOARD.dts: /home/ana/pulga/pulga-zephyr/boards/caninos/pulga/pulga.dts
-- Found devicetree overlay: /home/ana/pulga/pulga-zephyr/boards/shields/pulga-lora/pulga-lora.overlay
-- Generated zephyr.dts: /home/ana/pulga/build/zephyr/zephyr.dts
-- Generated devicetree_generated.h: /home/ana/pulga/build/zephyr/include/generated/zephyr/devicetree_generated.h
-- Including generated dts.cmake file: /home/ana/pulga/build/zephyr/dts.cmake

warning: Deprecated symbol SOC_DCDC_NRF52X is enabled.


warning: Deprecated symbol SOC_DCDC_NRF52X_HV is enabled.

Parsing /home/ana/pulga/zephyr/Kconfig
Loaded configuration '/home/ana/pulga/pulga-zephyr/boards/caninos/pulga/pulga_defconfig'
Merged configuration '/home/ana/pulga/pulga-zephyr/samples/lorawan-class-a-abp/prj.conf'
Configuration saved to '/home/ana/pulga/build/zephyr/.config'
Kconfig header saved to '/home/ana/pulga/build/zephyr/include/generated/zephyr/autoconf.h'
-- Found GnuLd: /opt/zephyr-sdk-0.16.8/arm-zephyr-eabi/arm-zephyr-eabi/bin/ld.bfd (found version "2.38")
-- The C compiler identification is GNU 12.2.0
-- The CXX compiler identification is GNU 12.2.0
-- The ASM compiler identification is GNU
-- Found assembler: /opt/zephyr-sdk-0.16.8/arm-zephyr-eabi/bin/arm-zephyr-eabi-gcc
-- Configuring done (4.1s)
-- Generating done (0.1s)
-- Build files have been written to: /home/ana/pulga/build
-- west build: building application
[1/180] Preparing syscall dependency handling

[3/180] Generating include/generated/zephyr/version.h
-- Zephyr version: 3.7.99 (/home/ana/pulga/zephyr), build: v3.7.0-1499-g65051c8a242e
[88/180] Building C object zephyr/subsys/lorawan/CMakeFiles/lo...ana/pulga/modules/lib/loramac-node/src/mac/region/Region.c.obj
FAILED: zephyr/subsys/lorawan/CMakeFiles/loramac-node.dir/home/ana/pulga/modules/lib/loramac-node/src/mac/region/Region.c.obj 
ccache /opt/zephyr-sdk-0.16.8/arm-zephyr-eabi/bin/arm-zephyr-eabi-gcc -DKERNEL -DK_HEAP_MEM_POOL_SIZE=4096 -DNRF52840_XXAA -DPICOLIBC_LONG_LONG_PRINTF_SCANF -DSOFT_SE -D__LINUX_ERRNO_EXTENSIONS__ -D__PROGRAM_START -D__ZEPHYR__=1 -I/home/ana/pulga/modules/lib/loramac-node/src/boards -I/home/ana/pulga/modules/lib/loramac-node/src/system -I/home/ana/pulga/modules/lib/loramac-node/src/radio -I/home/ana/pulga/modules/lib/loramac-node/src/mac -I/home/ana/pulga/modules/lib/loramac-node/src/mac/region -I/home/ana/pulga/modules/lib/loramac-node/src/apps/LoRaMac/common/LmHandler/packages -I/home/ana/pulga/build/zephyr/include/generated/zephyr -I/home/ana/pulga/zephyr/include -I/home/ana/pulga/build/zephyr/include/generated -I/home/ana/pulga/zephyr/soc/nordic -I/home/ana/pulga/zephyr/soc/nordic/nrf52/. -I/home/ana/pulga/zephyr/soc/nordic/common/. -I/home/ana/pulga/pulga-zephyr/include -I/home/ana/pulga/modules/hal/cmsis/CMSIS/Core/Include -I/home/ana/pulga/zephyr/modules/cmsis/. -I/home/ana/pulga/modules/hal/nordic/nrfx -I/home/ana/pulga/modules/hal/nordic/nrfx/drivers/include -I/home/ana/pulga/modules/hal/nordic/nrfx/mdk -I/home/ana/pulga/zephyr/modules/hal_nordic/nrfx/. -isystem /home/ana/pulga/zephyr/lib/libc/common/include -fno-strict-aliasing -Os -imacros /home/ana/pulga/build/zephyr/include/generated/zephyr/autoconf.h -fno-printf-return-value -fno-common -g -gdwarf-4 -fdiagnostics-color=always -mcpu=cortex-m4 -mthumb -mabi=aapcs -mfp16-format=ieee -mtp=soft --sysroot=/opt/zephyr-sdk-0.16.8/arm-zephyr-eabi/arm-zephyr-eabi -imacros /home/ana/pulga/zephyr/include/zephyr/toolchain/zephyr_stdint.h -Wall -Wformat -Wformat-security -Wno-format-zero-length -Wdouble-promotion -Wno-pointer-sign -Wpointer-arith -Wexpansion-to-defined -Wno-unused-but-set-variable -Werror=implicit-int -fno-pic -fno-pie -fno-asynchronous-unwind-tables -ftls-model=local-exec -fno-reorder-functions --param=min-pagesize=0 -fno-defer-pop -fmacro-prefix-map=/home/ana/pulga/pulga-zephyr/samples/lorawan-class-a-abp=CMAKE_SOURCE_DIR -fmacro-prefix-map=/home/ana/pulga/zephyr=ZEPHYR_BASE -fmacro-prefix-map=/home/ana/pulga=WEST_TOPDIR -ffunction-sections -fdata-sections --specs=picolibc.specs -std=c99 -MD -MT zephyr/subsys/lorawan/CMakeFiles/loramac-node.dir/home/ana/pulga/modules/lib/loramac-node/src/mac/region/Region.c.obj -MF zephyr/subsys/lorawan/CMakeFiles/loramac-node.dir/home/ana/pulga/modules/lib/loramac-node/src/mac/region/Region.c.obj.d -o zephyr/subsys/lorawan/CMakeFiles/loramac-node.dir/home/ana/pulga/modules/lib/loramac-node/src/mac/region/Region.c.obj -c /home/ana/pulga/modules/lib/loramac-node/src/mac/region/Region.c
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/Region.c:595:1: error: unknown type name 'PhyParam_t'; did you mean 'MibParam_t'?
  595 | PhyParam_t RegionGetPhyParam( LoRaMacRegion_t region, GetPhyParams_t* getPhy )
      | ^~~~~~~~~~
      | MibParam_t
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/Region.c:595:55: error: unknown type name 'GetPhyParams_t'
  595 | PhyParam_t RegionGetPhyParam( LoRaMacRegion_t region, GetPhyParams_t* getPhy )
      |                                                       ^~~~~~~~~~~~~~
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/Region.c:618:51: error: unknown type name 'SetBandTxDoneParams_t'
  618 | void RegionSetBandTxDone( LoRaMacRegion_t region, SetBandTxDoneParams_t* txDone )
      |                                                   ^~~~~~~~~~~~~~~~~~~~~
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/Region.c:640:50: error: unknown type name 'InitDefaultsParams_t'
  640 | void RegionInitDefaults( LoRaMacRegion_t region, InitDefaultsParams_t* params )
      |                                                  ^~~~~~~~~~~~~~~~~~~~
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/Region.c:662:44: error: unknown type name 'VerifyParams_t'
  662 | bool RegionVerify( LoRaMacRegion_t region, VerifyParams_t* verify, PhyAttribute_t phyAttribute )
      |                                            ^~~~~~~~~~~~~~
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/Region.c:662:68: error: unknown type name 'PhyAttribute_t'
  662 | bool RegionVerify( LoRaMacRegion_t region, VerifyParams_t* verify, PhyAttribute_t phyAttribute )
      |                                                                    ^~~~~~~~~~~~~~
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/Region.c:684:49: error: unknown type name 'ApplyCFListParams_t'
  684 | void RegionApplyCFList( LoRaMacRegion_t region, ApplyCFListParams_t* applyCFList )
      |                                                 ^~~~~~~~~~~~~~~~~~~
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/Region.c:706:49: error: unknown type name 'ChanMaskSetParams_t'; did you mean 'ChannelParams_t'?
  706 | bool RegionChanMaskSet( LoRaMacRegion_t region, ChanMaskSetParams_t* chanMaskSet )
      |                                                 ^~~~~~~~~~~~~~~~~~~
      |                                                 ChannelParams_t
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/Region.c:728:120: error: unknown type name 'RxConfigParams_t'; did you mean 'RxChannelParams_t'?
  728 | void RegionComputeRxWindowParameters( LoRaMacRegion_t region, int8_t datarate, uint8_t minRxSymbols, uint32_t rxError, RxConfigParams_t *rxConfigParams )
      |                                                                                                                        ^~~~~~~~~~~~~~~~
      |                                                                                                                        RxChannelParams_t
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/Region.c:750:46: error: unknown type name 'RxConfigParams_t'; did you mean 'RxChannelParams_t'?
  750 | bool RegionRxConfig( LoRaMacRegion_t region, RxConfigParams_t* rxConfig, int8_t* datarate )
      |                                              ^~~~~~~~~~~~~~~~
      |                                              RxChannelParams_t
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/Region.c:772:46: error: unknown type name 'TxConfigParams_t'
  772 | bool RegionTxConfig( LoRaMacRegion_t region, TxConfigParams_t* txConfig, int8_t* txPower, TimerTime_t* txTimeOnAir )
      |                                              ^~~~~~~~~~~~~~~~
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/Region.c:794:51: error: unknown type name 'LinkAdrReqParams_t'
  794 | uint8_t RegionLinkAdrReq( LoRaMacRegion_t region, LinkAdrReqParams_t* linkAdrReq, int8_t* drOut, int8_t* txPowOut, uint8_t* nbRepOut, uint8_t* nbBytesParsed )
      |                                                   ^~~~~~~~~~~~~~~~~~
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/Region.c:816:56: error: unknown type name 'RxParamSetupReqParams_t'
  816 | uint8_t RegionRxParamSetupReq( LoRaMacRegion_t region, RxParamSetupReqParams_t* rxParamSetupReq )
      |                                                        ^~~~~~~~~~~~~~~~~~~~~~~
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/Region.c:838:53: error: unknown type name 'NewChannelReqParams_t'; did you mean 'RxChannelParams_t'?
  838 | int8_t RegionNewChannelReq( LoRaMacRegion_t region, NewChannelReqParams_t* newChannelReq )
      |                                                     ^~~~~~~~~~~~~~~~~~~~~
      |                                                     RxChannelParams_t
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/Region.c:860:55: error: unknown type name 'TxParamSetupReqParams_t'
  860 | int8_t RegionTxParamSetupReq( LoRaMacRegion_t region, TxParamSetupReqParams_t* txParamSetupReq )
      |                                                       ^~~~~~~~~~~~~~~~~~~~~~~
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/Region.c:882:52: error: unknown type name 'DlChannelReqParams_t'; did you mean 'RxChannelParams_t'?
  882 | int8_t RegionDlChannelReq( LoRaMacRegion_t region, DlChannelReqParams_t* dlChannelReq )
      |                                                    ^~~~~~~~~~~~~~~~~~~~
      |                                                    RxChannelParams_t
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/Region.c:904:69: error: unknown type name 'AlternateDrType_t'
  904 | int8_t RegionAlternateDr( LoRaMacRegion_t region, int8_t currentDr, AlternateDrType_t type )
      |                                                                     ^~~~~~~~~~~~~~~~~
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/Region.c:926:60: error: unknown type name 'NextChanParams_t'
  926 | LoRaMacStatus_t RegionNextChannel( LoRaMacRegion_t region, NextChanParams_t* nextChanParams, uint8_t* channel, TimerTime_t* time, TimerTime_t* aggregatedTimeOff )
      |                                                            ^~~~~~~~~~~~~~~~
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/Region.c:948:59: error: unknown type name 'ChannelAddParams_t'; did you mean 'ChannelParams_t'?
  948 | LoRaMacStatus_t RegionChannelAdd( LoRaMacRegion_t region, ChannelAddParams_t* channelAdd )
      |                                                           ^~~~~~~~~~~~~~~~~~
      |                                                           ChannelParams_t
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/Region.c:970:52: error: unknown type name 'ChannelRemoveParams_t'; did you mean 'ChannelParams_t'?
  970 | bool RegionChannelsRemove( LoRaMacRegion_t region, ChannelRemoveParams_t* channelRemove )
      |                                                    ^~~~~~~~~~~~~~~~~~~~~
      |                                                    ChannelParams_t
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/Region.c:1014:51: error: unknown type name 'RxBeaconSetup_t'
 1014 | void RegionRxBeaconSetup( LoRaMacRegion_t region, RxBeaconSetup_t* rxBeaconSetup, uint8_t* outDr )
      |                                                   ^~~~~~~~~~~~~~~
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/Region.c: In function 'RegionGetVersion':
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/Region.c:1040:21: error: 'REGION_VERSION' undeclared (first use in this function)
 1040 |     version.Value = REGION_VERSION;
      |                     ^~~~~~~~~~~~~~
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/Region.c:1040:21: note: each undeclared identifier is reported only once for each function it appears in
[90/180] Building C object zephyr/subsys/lorawan/CMakeFiles/lo...ulga/modules/lib/loramac-node/src/mac/region/RegionLA915.c.obj
FAILED: zephyr/subsys/lorawan/CMakeFiles/loramac-node.dir/home/ana/pulga/modules/lib/loramac-node/src/mac/region/RegionLA915.c.obj 
ccache /opt/zephyr-sdk-0.16.8/arm-zephyr-eabi/bin/arm-zephyr-eabi-gcc -DKERNEL -DK_HEAP_MEM_POOL_SIZE=4096 -DNRF52840_XXAA -DPICOLIBC_LONG_LONG_PRINTF_SCANF -DSOFT_SE -D__LINUX_ERRNO_EXTENSIONS__ -D__PROGRAM_START -D__ZEPHYR__=1 -I/home/ana/pulga/modules/lib/loramac-node/src/boards -I/home/ana/pulga/modules/lib/loramac-node/src/system -I/home/ana/pulga/modules/lib/loramac-node/src/radio -I/home/ana/pulga/modules/lib/loramac-node/src/mac -I/home/ana/pulga/modules/lib/loramac-node/src/mac/region -I/home/ana/pulga/modules/lib/loramac-node/src/apps/LoRaMac/common/LmHandler/packages -I/home/ana/pulga/build/zephyr/include/generated/zephyr -I/home/ana/pulga/zephyr/include -I/home/ana/pulga/build/zephyr/include/generated -I/home/ana/pulga/zephyr/soc/nordic -I/home/ana/pulga/zephyr/soc/nordic/nrf52/. -I/home/ana/pulga/zephyr/soc/nordic/common/. -I/home/ana/pulga/pulga-zephyr/include -I/home/ana/pulga/modules/hal/cmsis/CMSIS/Core/Include -I/home/ana/pulga/zephyr/modules/cmsis/. -I/home/ana/pulga/modules/hal/nordic/nrfx -I/home/ana/pulga/modules/hal/nordic/nrfx/drivers/include -I/home/ana/pulga/modules/hal/nordic/nrfx/mdk -I/home/ana/pulga/zephyr/modules/hal_nordic/nrfx/. -isystem /home/ana/pulga/zephyr/lib/libc/common/include -fno-strict-aliasing -Os -imacros /home/ana/pulga/build/zephyr/include/generated/zephyr/autoconf.h -fno-printf-return-value -fno-common -g -gdwarf-4 -fdiagnostics-color=always -mcpu=cortex-m4 -mthumb -mabi=aapcs -mfp16-format=ieee -mtp=soft --sysroot=/opt/zephyr-sdk-0.16.8/arm-zephyr-eabi/arm-zephyr-eabi -imacros /home/ana/pulga/zephyr/include/zephyr/toolchain/zephyr_stdint.h -Wall -Wformat -Wformat-security -Wno-format-zero-length -Wdouble-promotion -Wno-pointer-sign -Wpointer-arith -Wexpansion-to-defined -Wno-unused-but-set-variable -Werror=implicit-int -fno-pic -fno-pie -fno-asynchronous-unwind-tables -ftls-model=local-exec -fno-reorder-functions --param=min-pagesize=0 -fno-defer-pop -fmacro-prefix-map=/home/ana/pulga/pulga-zephyr/samples/lorawan-class-a-abp=CMAKE_SOURCE_DIR -fmacro-prefix-map=/home/ana/pulga/zephyr=ZEPHYR_BASE -fmacro-prefix-map=/home/ana/pulga=WEST_TOPDIR -ffunction-sections -fdata-sections --specs=picolibc.specs -std=c99 -MD -MT zephyr/subsys/lorawan/CMakeFiles/loramac-node.dir/home/ana/pulga/modules/lib/loramac-node/src/mac/region/RegionLA915.c.obj -MF zephyr/subsys/lorawan/CMakeFiles/loramac-node.dir/home/ana/pulga/modules/lib/loramac-node/src/mac/region/RegionLA915.c.obj.d -o zephyr/subsys/lorawan/CMakeFiles/loramac-node.dir/home/ana/pulga/modules/lib/loramac-node/src/mac/region/RegionLA915.c.obj -c /home/ana/pulga/modules/lib/loramac-node/src/mac/region/RegionLA915.c
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/RegionLA915.c: In function 'RegionLA915InitDefaults':
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/RegionLA915.c:340:28: error: 'RegionNvmDataGroup1_t' {aka 'struct sRegionNvmDataGroup1'} has no member named 'JoinChannelGroupsCurrentIndex'
  340 |             RegionNvmGroup1->JoinChannelGroupsCurrentIndex = 0;
      |                            ^~
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/RegionLA915.c:343:28: error: 'RegionNvmDataGroup1_t' {aka 'struct sRegionNvmDataGroup1'} has no member named 'JoinTrialsCounter'
  343 |             RegionNvmGroup1->JoinTrialsCounter = 0;
      |                            ^~
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/RegionLA915.c:376:54: error: 'RegionNvmDataGroup1_t' {aka 'struct sRegionNvmDataGroup1'} has no member named 'ChannelsMaskRemaining'
  376 |             RegionCommonChanMaskCopy( RegionNvmGroup1->ChannelsMaskRemaining, RegionNvmGroup2->ChannelsMask, CHANNELS_MASK_SIZE );
      |                                                      ^~
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/RegionLA915.c:390:32: error: 'RegionNvmDataGroup1_t' {aka 'struct sRegionNvmDataGroup1'} has no member named 'ChannelsMaskRemaining'
  390 |                 RegionNvmGroup1->ChannelsMaskRemaining[i] &= RegionNvmGroup2->ChannelsMask[i];
      |                                ^~
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/RegionLA915.c: In function 'RegionLA915ApplyCFList':
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/RegionLA915.c:471:24: error: 'RegionNvmDataGroup1_t' {aka 'struct sRegionNvmDataGroup1'} has no member named 'ChannelsMaskRemaining'
  471 |         RegionNvmGroup1->ChannelsMaskRemaining[chMaskItr] &= RegionNvmGroup2->ChannelsMask[chMaskItr];
      |                        ^~
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/RegionLA915.c: In function 'RegionLA915ChanMaskSet':
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/RegionLA915.c:488:32: error: 'RegionNvmDataGroup1_t' {aka 'struct sRegionNvmDataGroup1'} has no member named 'ChannelsMaskRemaining'
  488 |                 RegionNvmGroup1->ChannelsMaskRemaining[i] &= RegionNvmGroup2->ChannelsMask[i];
      |                                ^~
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/RegionLA915.c: In function 'RegionLA915LinkAdrReq':
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/RegionLA915.c:715:24: error: 'RegionNvmDataGroup1_t' {aka 'struct sRegionNvmDataGroup1'} has no member named 'ChannelsMaskRemaining'
  715 |         RegionNvmGroup1->ChannelsMaskRemaining[0] &= RegionNvmGroup2->ChannelsMask[0];
      |                        ^~
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/RegionLA915.c:716:24: error: 'RegionNvmDataGroup1_t' {aka 'struct sRegionNvmDataGroup1'} has no member named 'ChannelsMaskRemaining'
  716 |         RegionNvmGroup1->ChannelsMaskRemaining[1] &= RegionNvmGroup2->ChannelsMask[1];
      |                        ^~
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/RegionLA915.c:717:24: error: 'RegionNvmDataGroup1_t' {aka 'struct sRegionNvmDataGroup1'} has no member named 'ChannelsMaskRemaining'
  717 |         RegionNvmGroup1->ChannelsMaskRemaining[2] &= RegionNvmGroup2->ChannelsMask[2];
      |                        ^~
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/RegionLA915.c:718:24: error: 'RegionNvmDataGroup1_t' {aka 'struct sRegionNvmDataGroup1'} has no member named 'ChannelsMaskRemaining'
  718 |         RegionNvmGroup1->ChannelsMaskRemaining[3] &= RegionNvmGroup2->ChannelsMask[3];
      |                        ^~
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/RegionLA915.c:719:24: error: 'RegionNvmDataGroup1_t' {aka 'struct sRegionNvmDataGroup1'} has no member named 'ChannelsMaskRemaining'
  719 |         RegionNvmGroup1->ChannelsMaskRemaining[4] = RegionNvmGroup2->ChannelsMask[4];
      |                        ^~
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/RegionLA915.c:720:24: error: 'RegionNvmDataGroup1_t' {aka 'struct sRegionNvmDataGroup1'} has no member named 'ChannelsMaskRemaining'
  720 |         RegionNvmGroup1->ChannelsMaskRemaining[5] = RegionNvmGroup2->ChannelsMask[5];
      |                        ^~
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/RegionLA915.c: In function 'RegionLA915AlternateDr':
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/RegionLA915.c:786:24: error: 'RegionNvmDataGroup1_t' {aka 'struct sRegionNvmDataGroup1'} has no member named 'JoinTrialsCounter'
  786 |         RegionNvmGroup1->JoinTrialsCounter++;
      |                        ^~
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/RegionLA915.c:790:24: error: 'RegionNvmDataGroup1_t' {aka 'struct sRegionNvmDataGroup1'} has no member named 'JoinTrialsCounter'
  790 |         RegionNvmGroup1->JoinTrialsCounter--;
      |                        ^~
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/RegionLA915.c:793:24: error: 'RegionNvmDataGroup1_t' {aka 'struct sRegionNvmDataGroup1'} has no member named 'JoinTrialsCounter'
  793 |     if( RegionNvmGroup1->JoinTrialsCounter % 9 == 0 )
      |                        ^~
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/RegionLA915.c: In function 'RegionLA915NextChannel':
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/RegionLA915.c:815:51: error: 'RegionNvmDataGroup1_t' {aka 'struct sRegionNvmDataGroup1'} has no member named 'ChannelsMaskRemaining'
  815 |     if( RegionCommonCountChannels( RegionNvmGroup1->ChannelsMaskRemaining, 0, 4 ) == 0 )
      |                                                   ^~
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/RegionLA915.c:817:50: error: 'RegionNvmDataGroup1_t' {aka 'struct sRegionNvmDataGroup1'} has no member named 'ChannelsMaskRemaining'
  817 |         RegionCommonChanMaskCopy( RegionNvmGroup1->ChannelsMaskRemaining, RegionNvmGroup2->ChannelsMask, 4  );
      |                                                  ^~
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/RegionLA915.c:819:24: error: 'RegionNvmDataGroup1_t' {aka 'struct sRegionNvmDataGroup1'} has no member named 'JoinChannelGroupsCurrentIndex'
  819 |         RegionNvmGroup1->JoinChannelGroupsCurrentIndex = 0;
      |                        ^~
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/RegionLA915.c:824:30: error: 'RegionNvmDataGroup1_t' {aka 'struct sRegionNvmDataGroup1'} has no member named 'ChannelsMaskRemaining'
  824 |         if( ( RegionNvmGroup1->ChannelsMaskRemaining[4] & CHANNELS_MASK_500KHZ_MASK ) == 0 )
      |                              ^~
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/RegionLA915.c:826:28: error: 'RegionNvmDataGroup1_t' {aka 'struct sRegionNvmDataGroup1'} has no member named 'ChannelsMaskRemaining'
  826 |             RegionNvmGroup1->ChannelsMaskRemaining[4] = RegionNvmGroup2->ChannelsMask[4];
      |                            ^~
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/RegionLA915.c:833:55: error: 'RegionNvmDataGroup1_t' {aka 'struct sRegionNvmDataGroup1'} has no member named 'ChannelsMaskRemaining'
  833 |     countChannelsParams.ChannelsMask = RegionNvmGroup1->ChannelsMaskRemaining;
      |                                                       ^~
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/RegionLA915.c:870:92: error: 'RegionNvmDataGroup1_t' {aka 'struct sRegionNvmDataGroup1'} has no member named 'ChannelsMaskRemaining'
  870 |                 if( RegionBaseUSComputeNext125kHzJoinChannel( ( uint16_t* ) RegionNvmGroup1->ChannelsMaskRemaining,
      |                                                                                            ^~
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/RegionLA915.c:871:37: error: 'RegionNvmDataGroup1_t' {aka 'struct sRegionNvmDataGroup1'} has no member named 'JoinChannelGroupsCurrentIndex'
  871 |                     &RegionNvmGroup1->JoinChannelGroupsCurrentIndex, channel ) == LORAMAC_STATUS_PARAMETER_INVALID )
      |                                     ^~
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/RegionLA915.c:881:43: error: 'RegionNvmDataGroup1_t' {aka 'struct sRegionNvmDataGroup1'} has no member named 'ChannelsMaskRemaining'
  881 |                 while( ( ( RegionNvmGroup1->ChannelsMaskRemaining[4] & CHANNELS_MASK_500KHZ_MASK ) & ( 1 << i ) ) == 0 )
      |                                           ^~
/home/ana/pulga/modules/lib/loramac-node/src/mac/region/RegionLA915.c:890:49: error: 'RegionNvmDataGroup1_t' {aka 'struct sRegionNvmDataGroup1'} has no member named 'ChannelsMaskRemaining'
  890 |         RegionCommonChanDisable( RegionNvmGroup1->ChannelsMaskRemaining, *channel, LA915_MAX_NB_CHANNELS );
      |                                                 ^~
[97/180] Building C object zephyr/subsys/lorawan/CMakeFiles/lo.../home/ana/pulga/modules/lib/loramac-node/src/mac/LoRaMac.c.obj
ninja: build stopped: subcommand failed.
FATAL ERROR: command exited with status 1: /usr/bin/cmake --build /home/ana/pulga/build

[mluis1]

The LoRa Alliance does not specify an LA915 region.

The region to be used in Brazil is AU915 specification.

As LA915 is not something official from the Alliance there is no need to provide a PR as it will not be accepted.

[anacforcelli]

Even though it is not official, the support for it might be needed since it's used by the American Tower networks.

[anacforcelli]

I just committed the changes in my fork at github.com/anacforcelli/loramac-node