Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: blank preset - all samplers disabled. #1127

Open
morbidCode opened this issue Sep 17, 2024 · 2 comments
Open

Feature request: blank preset - all samplers disabled. #1127

morbidCode opened this issue Sep 17, 2024 · 2 comments

Comments

@morbidCode
Copy link

Hi,

I noticed that in some models huggingface page, They have recommended samplers like temperature, min_p, etc and no other values for other samplers. I think it means all other samplers are disabled. Same goes for new samplers like XTC, where you only tinker with DRY and min_p (and possibly temperature?) and ignore the rest. Problem is the default values for a sampler can be different (I.E. top_p=1, top_k =0), and so someone might accidentally leave some samplers on while trying to adjust the samplers into the recommended settings by the model.

My suggestion: let’s add a preset (blank preset?) where all samplers start off disabled, and then users can enable the ones they actually want.

What do you think?

@LostRuins
Copy link
Owner

Sure, I can do that.

@LostRuins
Copy link
Owner

Added in latest version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants